jenkins-bot has submitted this change and it was merged.
Change subject: Use target factory to create target
......................................................................
Use target factory to create target
Change-Id: I56006a18fe048275340be8f4f027a0c6bb6d13f4
Depends-On: Iab0d5be611ece7038234551c4847b07517b4348d
---
M resources/mobile.editor.ve/VisualEditorOverlay.js
M resources/mobile.editor.ve/ve.init.mw.MobileFrontendArticleTarget.js
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Florianschmidtwelzow: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mobile.editor.ve/VisualEditorOverlay.js
b/resources/mobile.editor.ve/VisualEditorOverlay.js
index e8a80ea..bf86066 100644
--- a/resources/mobile.editor.ve/VisualEditorOverlay.js
+++ b/resources/mobile.editor.ve/VisualEditorOverlay.js
@@ -62,7 +62,7 @@
mw.loader.using( 'ext.visualEditor.targetLoader' )
.then( mw.libs.ve.targetLoader.loadModules )
.then( function () {
- overlay.target = new
ve.init.mw.MobileFrontendArticleTarget( overlay, {
+ overlay.target =
ve.init.mw.targetFactory.create( 'article', overlay, {
$element: overlay.$el,
// || undefined so that
scrolling is not triggered for the lead (0) section
// (which has no header to
scroll to)
diff --git
a/resources/mobile.editor.ve/ve.init.mw.MobileFrontendArticleTarget.js
b/resources/mobile.editor.ve/ve.init.mw.MobileFrontendArticleTarget.js
index 89e6691..8dd4c69 100644
--- a/resources/mobile.editor.ve/ve.init.mw.MobileFrontendArticleTarget.js
+++ b/resources/mobile.editor.ve/ve.init.mw.MobileFrontendArticleTarget.js
@@ -241,3 +241,7 @@
window.history.back();
};
+
+/* Registration */
+
+ve.init.mw.targetFactory.register( ve.init.mw.MobileFrontendArticleTarget );
--
To view, visit https://gerrit.wikimedia.org/r/284875
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56006a18fe048275340be8f4f027a0c6bb6d13f4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
