Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/284933

Change subject: Fix EventRelayerKafka IDEA errors
......................................................................

Fix EventRelayerKafka IDEA errors

Change-Id: I2808cb3cefb4d97f5ae2650554076c92b0d877d9
---
M includes/libs/eventrelayer/EventRelayerKafka.php
1 file changed, 5 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/33/284933/1

diff --git a/includes/libs/eventrelayer/EventRelayerKafka.php 
b/includes/libs/eventrelayer/EventRelayerKafka.php
index 3555a23..999eb43 100644
--- a/includes/libs/eventrelayer/EventRelayerKafka.php
+++ b/includes/libs/eventrelayer/EventRelayerKafka.php
@@ -7,7 +7,6 @@
  * 'relayerConfig' => [ 'class' => 'EventRelayerKafka', 'KafkaEventHost' => 
'localhost:9092' ],
  */
 class EventRelayerKafka extends EventRelayer {
-
        /**
         * Configuration.
         *
@@ -25,9 +24,11 @@
        /**
         * Create Kafka producer.
         *
-        * @param Config $config
+        * @param array $params
         */
        public function __construct( array $params ) {
+               parent::__construct( $params );
+
                $this->config = new HashConfig( $params );
                if ( !$this->config->has( 'KafkaEventHost' ) ) {
                        throw new InvalidArgumentException( "KafkaEventHost 
must be configured" );
@@ -40,17 +41,12 @@
         */
        protected function getKafkaProducer() {
                if ( !$this->producer ) {
-                       $this->producer = Produce::getInstance( null, null, 
$this->config->get( 'KafkaEventHost' ) );
+                       $this->producer = Produce::getInstance(
+                               null, null, $this->config->get( 
'KafkaEventHost' ) );
                }
                return $this->producer;
        }
 
-       /**
-        * (non-PHPdoc)
-        *
-        * @see EventRelayer::doNotify()
-        *
-        */
        protected function doNotify( $channel, array $events ) {
                $jsonEvents = array_map( 'json_encode', $events );
                try {

-- 
To view, visit https://gerrit.wikimedia.org/r/284933
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2808cb3cefb4d97f5ae2650554076c92b0d877d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to