TheDJ has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/284985

Change subject: Make sure the width/height attribute is a number
......................................................................

Make sure the width/height attribute is a number

Change-Id: I2fbaa18e565cd348f48a8aacbfae699eaeae74e6
---
M TimedMediaTransformOutput.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler 
refs/changes/85/284985/1

diff --git a/TimedMediaTransformOutput.php b/TimedMediaTransformOutput.php
index 8365e0a..3345327 100644
--- a/TimedMediaTransformOutput.php
+++ b/TimedMediaTransformOutput.php
@@ -431,9 +431,9 @@
 
                if ( $wgTmhWebPlayer === 'videojs' ) {
                        $mediaAttr['class'] = 'video-js ' . $wgVideoPlayerSkin;
-                       $mediaAttr['width'] = $width;
+                       $mediaAttr['width'] = intval( $width );
                        if ( $this->isVideo ) {
-                               $mediaAttr['height'] = $height;
+                               $mediaAttr['height'] = intval( $height );
                        } else {
                                unset( $mediaAttr['height'] );
                                unset( $mediaAttr['poster'] );

-- 
To view, visit https://gerrit.wikimedia.org/r/284985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fbaa18e565cd348f48a8aacbfae699eaeae74e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to