Skizzerz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/285140

Change subject: Pass through errors creating the main page to the installer.
......................................................................

Pass through errors creating the main page to the installer.

Right now, any errors from inserting the main page are silently ignored by
the installer, causing it to report success even in case of failure. Let's
fix that.

Change-Id: I1da3aa076eefa212b5cc0f796a48f944e8c06fd2
---
M includes/installer/Installer.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/40/285140/1

diff --git a/includes/installer/Installer.php b/includes/installer/Installer.php
index 3d1c860..d747707 100644
--- a/includes/installer/Installer.php
+++ b/includes/installer/Installer.php
@@ -1697,7 +1697,7 @@
                                wfMessage( 'mainpagedocfooter' 
)->inContentLanguage()->text()
                        );
 
-                       $page->doEditContent( $content,
+                       $status = $page->doEditContent( $content,
                                '',
                                EDIT_NEW,
                                false,

-- 
To view, visit https://gerrit.wikimedia.org/r/285140
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1da3aa076eefa212b5cc0f796a48f944e8c06fd2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Skizzerz <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to