jenkins-bot has submitted this change and it was merged. Change subject: mediawiki.special.upload.js: Remove spinner in .always() instead of .done() ......................................................................
mediawiki.special.upload.js: Remove spinner in .always() instead of .done() This removes the spinner even when the API request fails. Change-Id: Ic0f08312b9a1137772f5b6734256e7bd48d20fcf --- M resources/src/mediawiki.special/mediawiki.special.upload.js 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/src/mediawiki.special/mediawiki.special.upload.js b/resources/src/mediawiki.special/mediawiki.special.upload.js index 8c89ed9..945bfb0 100644 --- a/resources/src/mediawiki.special/mediawiki.special.upload.js +++ b/resources/src/mediawiki.special/mediawiki.special.upload.js @@ -74,8 +74,9 @@ if ( result.query ) { resultOut = result.query.pages[ result.query.pageids[ 0 ] ].imageinfo[ 0 ]; } - $spinnerDestCheck.remove(); uploadWarning.processResult( resultOut, uploadWarning.nameToCheck ); + } ).always( function () { + $spinnerDestCheck.remove(); } ); }, @@ -123,8 +124,9 @@ prop: 'text', pst: true } ).done( function ( result ) { - $spinnerLicense.remove(); uploadLicense.processResult( result, license ); + } ).always( function () { + $spinnerLicense.remove(); } ); }, -- To view, visit https://gerrit.wikimedia.org/r/283594 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0f08312b9a1137772f5b6734256e7bd48d20fcf Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Edokter <er...@darcoury.nl> Gerrit-Reviewer: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com> Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits