EBernhardson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/286079
Change subject: Make form errors stand out more
......................................................................
Make form errors stand out more
Change-Id: I75d700e008420aaf8d7ff030544217c8f883d66b
---
M views/score_query.twig
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/discernatron
refs/changes/79/286079/1
diff --git a/views/score_query.twig b/views/score_query.twig
index 99e2d53..36646e6 100644
--- a/views/score_query.twig
+++ b/views/score_query.twig
@@ -2,6 +2,18 @@
{% form_theme form _self %}
+{% block form_errors %}
+ {% spaceless %}
+ {% if errors|length > 0 %}
+ <div class="errors">
+ {% for error in errors %}
+ <p class="bg-danger">{{ error.message }}</li>
+ {% endfor %}
+ </div>
+ {% endif %}
+ {% endspaceless %}
+{% endblock %}
+
{% block head %}
{{ parent() }}
<style type="text/css">
@@ -16,6 +28,9 @@
}
.row.irrelevant {
background-color: #FF4040;
+ }
+ .errors p {
+ padding: 15px;
}
@media (max-width: 768px) {
.border-xs {
@@ -89,7 +104,7 @@
selected = parseInt(row.find('input:checked').val());
// Don't override real clicks. We have to check originalEvent
because toElement
- // isn't populated in firefox 46
+ // isn't populated in firefox 46
if ($(evt.toElement).is('label, input') ||
$(evt.originalEvent.target).is('label, input')) {
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/286079
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75d700e008420aaf8d7ff030544217c8f883d66b
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/discovery/discernatron
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
