EBernhardson has submitted this change and it was merged.
Change subject: Revert "Use the default form label rendering"
......................................................................
Revert "Use the default form label rendering"
Breaks the toggling by clicking the title. Also ends up adding an
unnecessary 'Token' label for the CSRF token that shouldn't exist.
This reverts commit 6134df17a5f6ee4cbf2bd6938e6cdddde177233c.
Change-Id: I8dda02eafb8e44836b9af1e0eb5afb8ba1a464d8
---
M views/score_query.twig
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
EBernhardson: Verified; Looks good to me, approved
diff --git a/views/score_query.twig b/views/score_query.twig
index 2b8fa16..cb19bd3 100644
--- a/views/score_query.twig
+++ b/views/score_query.twig
@@ -14,6 +14,10 @@
{% endspaceless %}
{% endblock %}
+{% block choice_label %}
+ {# no label, our form will just use buttons #}
+{% endblock %}
+
{% block head %}
{{ parent() }}
<style type="text/css">
@@ -76,7 +80,7 @@
{% for child in form %}
<div class="row border-xs border-sm">
- <div class="click-for-next col-md-3">{{ form_label(child)
}}</div>
+ <div class="click-for-next col-md-3">{{ child.vars.label
}}</div>
{% for choice in child %}
<div class="col-md-2 hidden-xs hidden-sm click-for-next">
{{ form_label(choice) }}
--
To view, visit https://gerrit.wikimedia.org/r/286098
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8dda02eafb8e44836b9af1e0eb5afb8ba1a464d8
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/discovery/discernatron
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org>
Gerrit-Reviewer: EBernhardson <ebernhard...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
