Gerrit Patch Uploader has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/286272

Change subject: Better JavaScript handling for return method
......................................................................

Better JavaScript handling for return method

The length selector can be reduced to just find the child of $tbody, as it will 
check to see if both $tbody and the child .collapsible exist.

Change-Id: If927a5ca79d12f4654a1af9bad97c9274cb501e9
---
M resources/src/mediawiki.action/mediawiki.action.view.metadata.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/72/286272/1

diff --git a/resources/src/mediawiki.action/mediawiki.action.view.metadata.js 
b/resources/src/mediawiki.action/mediawiki.action.view.metadata.js
index b1a63b0..4c75e33 100644
--- a/resources/src/mediawiki.action/mediawiki.action.view.metadata.js
+++ b/resources/src/mediawiki.action/mediawiki.action.view.metadata.js
@@ -14,7 +14,7 @@
                        $table = $( '#mw_metadata' ),
                        $tbody = $table.find( 'tbody' );
 
-               if ( !$tbody.length || !$tbody.find( '.collapsable' ).length ) {
+               if ( !$tbody.find( '.collapsable' ).length ) {
                        return;
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/286272
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If927a5ca79d12f4654a1af9bad97c9274cb501e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Cblair91 <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to