Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/287050
Change subject: Add a parameter to service::node for enabling or disabling the
service unit
......................................................................
Add a parameter to service::node for enabling or disabling the service unit
Add an 'enabled' parameter to service::node resources that controls whether or
not the systemd unit or upstart job for the service should be running. This is
passed through to the underlying base::service_unit resource. This allows a
misbehaving nonessential service to be disabled.
Change-Id: I6e3f99abf0ee68f39b39a24fe4cf0723cf143686
---
M modules/service/manifests/node.pp
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/50/287050/1
diff --git a/modules/service/manifests/node.pp
b/modules/service/manifests/node.pp
index fc7fe09..f7f23bc 100644
--- a/modules/service/manifests/node.pp
+++ b/modules/service/manifests/node.pp
@@ -8,6 +8,11 @@
#
# === Parameters
#
+# [*enable*]
+# Whether or not the systemd unit or upstart job for the service
+# should be running. This is passed through to the underlying
+# base::service_unit resource. Default: true.
+#
# [*port*]
# Port on which to run the service
#
@@ -98,6 +103,7 @@
#
define service::node(
$port,
+ $enable = true,
$config = undef,
$full_config = false,
$no_workers = 'ncpu',
@@ -241,7 +247,7 @@
template_name => 'node',
refresh => $auto_refresh,
service_params => {
- enable => true,
+ enable => $enable,
hasstatus => true,
hasrestart => true,
},
--
To view, visit https://gerrit.wikimedia.org/r/287050
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e3f99abf0ee68f39b39a24fe4cf0723cf143686
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
