GWicke has submitted this change and it was merged. Change subject: Fixed incorrect use of DOM.insertBefore API. ......................................................................
Fixed incorrect use of DOM.insertBefore API. * When I wanted to add an element in the first child position, I incorrectly passed 'null' which added it to the last child position which then introduces an infinite loop when processing mw:DiffMarkers in certain scenarios. Change-Id: I986f8e92ecd762f6f5a9c284b87ba6daa0f13fc2 --- M js/lib/mediawiki.WikitextSerializer.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: GWicke: Verified; Looks good to me, approved jenkins-bot: Checked -- To view, visit https://gerrit.wikimedia.org/r/44831 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I986f8e92ecd762f6f5a9c284b87ba6daa0f13fc2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry <ssas...@wikimedia.org> Gerrit-Reviewer: GWicke <gwi...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
