jenkins-bot has submitted this change and it was merged.
Change subject: Remove reflection that doesn't seem to be needed any more
......................................................................
Remove reflection that doesn't seem to be needed any more
Change-Id: I439429cec578caf17d56290f2c4729f1fa984b20
---
M TestHelper.php
1 file changed, 1 insertion(+), 7 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/TestHelper.php b/TestHelper.php
index 0f669cf..c29fbbe 100644
--- a/TestHelper.php
+++ b/TestHelper.php
@@ -49,7 +49,7 @@
$standard = $this->rootDir . '/ruleset.xml';
}
$defaults = $this->phpcs->getDefaults();
- // $standard = $this->rootDir . '/ruleset.xml';
+
if (
defined( 'PHP_CodeSniffer::VERSION' ) &&
version_compare( PHP_CodeSniffer::VERSION, '1.5.0' ) !=
-1
@@ -61,12 +61,6 @@
'files' => [ $file ],
'standard' => $standard,
] + $defaults;
-
- // New PHPCS has a strange issue where the method arguments
- // are not stored on the instance causing weird errors.
- $reflection = new ReflectionProperty( $this->phpcs, 'values' );
- $reflection->setAccessible( true );
- $reflection->setValue( $this->phpcs, $options );
ob_start();
$this->phpcs->process( $options );
--
To view, visit https://gerrit.wikimedia.org/r/287402
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I439429cec578caf17d56290f2c4729f1fa984b20
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
