jenkins-bot has submitted this change and it was merged.
Change subject: Log Exceptions during change dispatching
......................................................................
Log Exceptions during change dispatching
Just use the normal "exception" log channel, no
need to have an own channel here.
Bug: T134585
Change-Id: Ieedfb55ee9b2849a9f6ffda367a1527145c78e75
---
M repo/maintenance/dispatchChanges.php
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/maintenance/dispatchChanges.php
b/repo/maintenance/dispatchChanges.php
index 4e29a1f..9a5a160 100644
--- a/repo/maintenance/dispatchChanges.php
+++ b/repo/maintenance/dispatchChanges.php
@@ -5,6 +5,7 @@
use Exception;
use Maintenance;
use MWException;
+use MWExceptionHandler;
use RequestContext;
use Wikibase\Lib\Reporting\ObservableMessageReporter;
use Wikibase\Lib\Reporting\ReportingExceptionHandler;
@@ -222,6 +223,9 @@
}
} catch ( Exception $ex ) {
$stats->increment(
'wikibase.repo.dispatchChanges.exception' );
+
+ MWExceptionHandler::logException( $ex );
+
if ( $c < $maxPasses ) {
$this->log( "ERROR: $ex; sleeping for
{$delay} seconds" );
sleep( $delay );
--
To view, visit https://gerrit.wikimedia.org/r/287559
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieedfb55ee9b2849a9f6ffda367a1527145c78e75
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <h...@online.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: JanZerebecki <jan.wikime...@zerebecki.de>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
