Milimetric has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288007
Change subject: Improve style and formatting
......................................................................
Improve style and formatting
Change-Id: I66709cae7e598ac037873d203c90a9608afc98f3
---
M src/components/breakdown-toggle/breakdown-toggle.html
M src/components/metrics-by-project-layout/metrics-by-project-layout.js
M src/components/visualizers/dygraphs-timeseries/bindings.js
M src/layouts/metrics-by-project/01_styles.css
4 files changed, 10 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/dashiki
refs/changes/07/288007/1
diff --git a/src/components/breakdown-toggle/breakdown-toggle.html
b/src/components/breakdown-toggle/breakdown-toggle.html
index c677a67..e4f1199 100644
--- a/src/components/breakdown-toggle/breakdown-toggle.html
+++ b/src/components/breakdown-toggle/breakdown-toggle.html
@@ -9,12 +9,12 @@
<div class="colored menu">
<!-- ko foreach: breakdownState().columns()-->
<div class="item">
- <label>
+ <label class="clickable">
<i class="circle icon"></i>
<span data-bind="text: label"></span>
<input type="checkbox" data-bind="disable: selected() &&
$parents[0].isOnlyOneSelected(),checked: selected ">
- <svg height="10" width="80">
+ <svg height="10" width="100%">
<path stroke="white"
data-bind="attr: {'stroke-dasharray': pattern}"
d="M6 5 l215 0" />
diff --git
a/src/components/metrics-by-project-layout/metrics-by-project-layout.js
b/src/components/metrics-by-project-layout/metrics-by-project-layout.js
index 43460dd..ada6f04 100644
--- a/src/components/metrics-by-project-layout/metrics-by-project-layout.js
+++ b/src/components/metrics-by-project-layout/metrics-by-project-layout.js
@@ -26,8 +26,8 @@
self.breakdownState = ko.observable();
self.patterns = [
'', [5, 5],
- [15, 15],
- [30, 5],
+ [15, 5],
+ [45, 5],
];
self.defaultMetrics = ko.observable([]);
@@ -89,4 +89,4 @@
viewModel: WikimetricsLayout,
template: templateMarkup
};
-});
\ No newline at end of file
+});
diff --git a/src/components/visualizers/dygraphs-timeseries/bindings.js
b/src/components/visualizers/dygraphs-timeseries/bindings.js
index 9d2d8ca..a6cebb5 100644
--- a/src/components/visualizers/dygraphs-timeseries/bindings.js
+++ b/src/components/visualizers/dygraphs-timeseries/bindings.js
@@ -43,6 +43,7 @@
},
y: {
valueFormatter: val.format,
+ axisLabelFormatter: val.format,
},
},
labels: ['Date'],
@@ -122,4 +123,4 @@
}
},
};
-});
\ No newline at end of file
+});
diff --git a/src/layouts/metrics-by-project/01_styles.css
b/src/layouts/metrics-by-project/01_styles.css
index 2dd9ecf..74a716b 100644
--- a/src/layouts/metrics-by-project/01_styles.css
+++ b/src/layouts/metrics-by-project/01_styles.css
@@ -6,6 +6,9 @@
font-family: "Nimbus Sans L","Liberation Sans","Helvetica
Neue","Helvetica","Arial",sans-serif;
}
+.clickable {
+ cursor: pointer;
+}
/* patches to semantic */
.delete.icon {
cursor: pointer;
--
To view, visit https://gerrit.wikimedia.org/r/288007
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66709cae7e598ac037873d203c90a9608afc98f3
Gerrit-PatchSet: 1
Gerrit-Project: analytics/dashiki
Gerrit-Branch: master
Gerrit-Owner: Milimetric <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
