[MediaWiki-commits] [Gerrit] Don't show arrow when slider is at either end - change (mediawiki...RevisionSlider)

[Addshore (Code Review)]

Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/288088

Change subject: Don't show arrow when slider is at either end
......................................................................

Don't show arrow when slider is at either end

Change-Id: I7fdced0e959ff9692375bb0fcb879f821308189a
---
M modules/ext.RevisionSlider.Slider.js
M modules/ext.RevisionSlider.SliderView.js
2 files changed, 23 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider 
refs/changes/88/288088/1

diff --git a/modules/ext.RevisionSlider.Slider.js 
b/modules/ext.RevisionSlider.Slider.js
index 05dcd9f..d79e1ff 100644
--- a/modules/ext.RevisionSlider.Slider.js
+++ b/modules/ext.RevisionSlider.Slider.js
@@ -39,6 +39,18 @@
                        return this.firstVisibleRevisionIndex;
                },
 
+               getLastVisibleRevisionIndex: function () {
+                       return this.firstVisibleRevisionIndex + 
this.revisionsPerWindow - 1;
+               },
+
+               isAtStart: function () {
+                       return this.getFirstVisibleRevisionIndex() === 0;
+               },
+
+               isAtEnd: function () {
+                       return this.getLastVisibleRevisionIndex() === 
this.revisions.getLength() - 2;
+               },
+
                slide: function ( direction ) {
                        var highestPossibleFirstRev = 
this.revisions.getLength() - 1 - this.revisionsPerWindow;
 
diff --git a/modules/ext.RevisionSlider.SliderView.js 
b/modules/ext.RevisionSlider.SliderView.js
index 4a4d575..aabf6df 100644
--- a/modules/ext.RevisionSlider.SliderView.js
+++ b/modules/ext.RevisionSlider.SliderView.js
@@ -126,6 +126,17 @@
                        self.leftPointer.getView().getElement().draggable( 
'disable' );
                        self.rightPointer.getView().getElement().draggable( 
'disable' );
 
+                       if ( this.slider.isAtStart() ) {
+                               $( '.left-arrow' ).css( 'visibility', 'hidden' 
);
+                       } else {
+                               $( '.left-arrow' ).css( 'visibility', '' );
+                       }
+                       if ( this.slider.isAtEnd() ) {
+                               $( '.right-arrow' ).css( 'visibility', 'hidden' 
);
+                       } else {
+                               $( '.right-arrow' ).css( 'visibility', '' );
+                       }
+
                        this.$element.find( '.revisions-container' ).animate(
                                { scrollLeft: 
this.slider.getFirstVisibleRevisionIndex() * this.revisionWidth },
                                duration,

-- 
To view, visit https://gerrit.wikimedia.org/r/288088
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fdced0e959ff9692375bb0fcb879f821308189a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits