jenkins-bot has submitted this change and it was merged.
Change subject: Log URLs by default in dev builds
......................................................................
Log URLs by default in dev builds
This is slightly more verbose but is relevant to many changes,
especially for the Content Service.
Change-Id: I66094f3cce1907889021f681940a6fce0d1fbd52
---
M app/src/main/java/org/wikipedia/settings/Prefs.java
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
BearND: Looks good to me, approved
Mholloway: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/settings/Prefs.java
b/app/src/main/java/org/wikipedia/settings/Prefs.java
index af74123..ee0551b 100644
--- a/app/src/main/java/org/wikipedia/settings/Prefs.java
+++ b/app/src/main/java/org/wikipedia/settings/Prefs.java
@@ -108,8 +108,7 @@
}
public static boolean isShowDeveloperSettingsEnabled() {
- return getBoolean(R.string.preference_key_show_developer_settings,
- WikipediaApp.getInstance().isDevRelease());
+ return getBoolean(R.string.preference_key_show_developer_settings,
isDevRelease());
}
public static void setShowDeveloperSettingsEnabled(boolean enabled) {
@@ -284,7 +283,7 @@
public static Level getRetrofitLogLevel() {
String prefValue =
getString(R.string.preference_key_retrofit_log_level, null);
if (prefValue == null) {
- return Level.NONE;
+ return isDevRelease() ? Level.BASIC : Level.NONE;
}
switch (prefValue) {
case "BASIC":
@@ -395,5 +394,9 @@
return getBoolean(R.string.preference_key_show_link_previews, true);
}
+ private static boolean isDevRelease() {
+ return WikipediaApp.getInstance().isDevRelease();
+ }
+
private Prefs() { }
}
--
To view, visit https://gerrit.wikimedia.org/r/288001
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66094f3cce1907889021f681940a6fce0d1fbd52
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
