jenkins-bot has submitted this change and it was merged.
Change subject: Don't allow pointer clicks while timeline is sliding
......................................................................
Don't allow pointer clicks while timeline is sliding
Bug: T133279
Change-Id: I46add92298ac41b06437eef59f33a0ee64c4ccf0
---
M modules/ext.RevisionSlider.SliderView.js
1 file changed, 15 insertions(+), 4 deletions(-)
Approvals:
WMDE-Fisch: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.RevisionSlider.SliderView.js
b/modules/ext.RevisionSlider.SliderView.js
index 9f2ddb7..4a4d575 100644
--- a/modules/ext.RevisionSlider.SliderView.js
+++ b/modules/ext.RevisionSlider.SliderView.js
@@ -120,11 +120,22 @@
},
slide: function ( direction, duration ) {
- this.slider.slide( direction );
+ var self = this;
- this.$element.find( '.revisions-container' ).animate( {
- scrollLeft:
this.slider.getFirstVisibleRevisionIndex() * this.revisionWidth
- }, duration );
+ this.slider.slide( direction );
+ self.leftPointer.getView().getElement().draggable(
'disable' );
+ self.rightPointer.getView().getElement().draggable(
'disable' );
+
+ this.$element.find( '.revisions-container' ).animate(
+ { scrollLeft:
this.slider.getFirstVisibleRevisionIndex() * this.revisionWidth },
+ duration,
+ null,
+ function () {
+
self.leftPointer.getView().getElement().draggable( 'enable' );
+
self.rightPointer.getView().getElement().draggable( 'enable' );
+ }
+ );
+
this.leftPointer.getView().slideToSideOrPosition( this,
duration );
this.rightPointer.getView().slideToSideOrPosition(
this, duration );
},
--
To view, visit https://gerrit.wikimedia.org/r/288050
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46add92298ac41b06437eef59f33a0ee64c4ccf0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Gabriel Birke <[email protected]>
Gerrit-Reviewer: Jakob <[email protected]>
Gerrit-Reviewer: Kai Nissen (WMDE) <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: WMDE-Fisch <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
