WMDE-leszek has submitted this change and it was merged.
Change subject: Avoid changing the URL during SliderView test
......................................................................
Avoid changing the URL during SliderView test
This was super annoying as if you went to refresh
the test page to run the tests again it would take
you to some broken diff page instead...
Change-Id: I43ca8edd005aa3ef72b74a5d812cbe39bccaf332
---
M tests/RevisionSlider.SliderView.test.js
1 file changed, 11 insertions(+), 1 deletion(-)
Approvals:
WMDE-leszek: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/RevisionSlider.SliderView.test.js
b/tests/RevisionSlider.SliderView.test.js
index 86db974..c2c7cf6 100644
--- a/tests/RevisionSlider.SliderView.test.js
+++ b/tests/RevisionSlider.SliderView.test.js
@@ -2,10 +2,20 @@
var SliderView = mw.libs.revisionSlider.SliderView,
Slider = mw.libs.revisionSlider.Slider,
Revision = mw.libs.revisionSlider.Revision,
- RevisionList = mw.libs.revisionSlider.RevisionList;
+ RevisionList = mw.libs.revisionSlider.RevisionList,
+ startHistoryState, startHref;
QUnit.module( 'ext.RevisionSlider.SliderView' );
+ QUnit.testStart( function () {
+ startHistoryState = history.state;
+ startHref = window.location.href;
+ } );
+
+ QUnit.testDone( function () {
+ history.replaceState( startHistoryState, 'QUnit', startHref );
+ } );
+
QUnit.test( 'render', function ( assert ) {
var $container = $( '<div/>' ),
view = new SliderView( new Slider( new RevisionList( [
--
To view, visit https://gerrit.wikimedia.org/r/288431
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I43ca8edd005aa3ef72b74a5d812cbe39bccaf332
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Gabriel Birke <gabriel.bi...@wikimedia.de>
Gerrit-Reviewer: Jakob <jakob.warkot...@wikimedia.de>
Gerrit-Reviewer: Kai Nissen (WMDE) <kai.nis...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: WMDE-Fisch <christoph.fisc...@wikimedia.de>
Gerrit-Reviewer: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
