Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288948
Change subject: Add selector whitespace and double colon rules to styleline
......................................................................
Add selector whitespace and double colon rules to styleline
W3C recommends double colon for pseudo-elements (as opposed
to pseudo classes).
Change-Id: I17e0d23ddfedf64985495ab35d113ea08c03b1df
---
M .stylelintrc
M demos/ve/demo.css
M src/ce/styles/nodes/ve.ce.ContentBranchNode.css
M src/ce/styles/nodes/ve.ce.SectionNode.css
M src/ui/styles/ve.ui.Surface.css
5 files changed, 17 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/48/288948/1
diff --git a/.stylelintrc b/.stylelintrc
index 9787a10..c83d38a 100644
--- a/.stylelintrc
+++ b/.stylelintrc
@@ -53,5 +53,15 @@
"block-opening-brace-space-after": [ "always-single-line" ],
"block-opening-brace-space-before": [ "always" ],
+ "selector-combinator-space-after": [ "always" ],
+ "selector-combinator-space-before": [ "always" ],
+ "selector-no-vendor-prefix": true,
+ "selector-root-no-composition": true,
+ "selector-pseudo-element-colon-notation": [ "double" ],
+
+ "selector-list-comma-newline-after": [ "always" ],
+ "selector-list-comma-newline-before": [ "never-multi-line" ],
+ "selector-list-comma-space-after": [ "always-single-line" ],
+ "selector-list-comma-space-before": [ "never" ]
}
}
diff --git a/demos/ve/demo.css b/demos/ve/demo.css
index 8c1d8ce..32b61d7 100644
--- a/demos/ve/demo.css
+++ b/demos/ve/demo.css
@@ -118,11 +118,12 @@
list-style: none;
}
-.ve-filibuster-frame-expandable:before, .ve-filibuster-frame-collapsed:before {
+.ve-filibuster-frame-expandable::before,
+.ve-filibuster-frame-collapsed::before {
content: '+';
}
-.ve-filibuster-frame-expanded:before {
+.ve-filibuster-frame-expanded::before {
content: '-';
}
diff --git a/src/ce/styles/nodes/ve.ce.ContentBranchNode.css
b/src/ce/styles/nodes/ve.ce.ContentBranchNode.css
index a594c43..e047743 100644
--- a/src/ce/styles/nodes/ve.ce.ContentBranchNode.css
+++ b/src/ce/styles/nodes/ve.ce.ContentBranchNode.css
@@ -15,7 +15,7 @@
/* Hack for empty headings and paragraphs; can't use min-height because of IE
*/
-.ve-ce-contentBranchNode:empty:before {
+.ve-ce-contentBranchNode::empty::before {
content: url(
data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7
);
}
diff --git a/src/ce/styles/nodes/ve.ce.SectionNode.css
b/src/ce/styles/nodes/ve.ce.SectionNode.css
index 9919500..5cfce2a 100644
--- a/src/ce/styles/nodes/ve.ce.SectionNode.css
+++ b/src/ce/styles/nodes/ve.ce.SectionNode.css
@@ -5,8 +5,8 @@
*/
/* Prevent margin collapse across sections */
-.ve-ce-sectionNode:before,
-.ve-ce-sectionNode:after {
+.ve-ce-sectionNode::before,
+.ve-ce-sectionNode::after {
content: '\00a0';
display: block;
overflow: hidden;
diff --git a/src/ui/styles/ve.ui.Surface.css b/src/ui/styles/ve.ui.Surface.css
index 8fca85e..6788516 100644
--- a/src/ui/styles/ve.ui.Surface.css
+++ b/src/ui/styles/ve.ui.Surface.css
@@ -8,7 +8,7 @@
position: relative;
}
-.ve-ui-surface:after {
+.ve-ui-surface::after {
content: '.';
display: block;
clear: both;
--
To view, visit https://gerrit.wikimedia.org/r/288948
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I17e0d23ddfedf64985495ab35d113ea08c03b1df
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
