jenkins-bot has submitted this change and it was merged. Change subject: Defer DB update in NewUserMessagesView ......................................................................
Defer DB update in NewUserMessagesView Bug: T92357 Change-Id: I407f65dc20063d5bf7ba416e0a66c3a2635a2dca --- M pages/NewUserMessagesView.php 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Krinkle: Looks good to me, approved jenkins-bot: Verified diff --git a/pages/NewUserMessagesView.php b/pages/NewUserMessagesView.php index d2270f2..1a9063b 100644 --- a/pages/NewUserMessagesView.php +++ b/pages/NewUserMessagesView.php @@ -76,7 +76,10 @@ function showOnce() { NewMessages::recacheMessageCount( $this->user->getId() ); - $this->user->setNewtalk( false ); + $user = $this->user; + DeferredUpdates::addCallableUpdate( function () use ( $user ) { + $user->setNewtalk( false ); + } ); if ( $this->methodApplies( 'mark_as_unread' ) ) { $ids = explode( ',', $this->request->getVal( 'lqt_operand', '' ) ); -- To view, visit https://gerrit.wikimedia.org/r/288759 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I407f65dc20063d5bf7ba416e0a66c3a2635a2dca Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/LiquidThreads Gerrit-Branch: master Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Siebrand <siebr...@kitano.nl> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits