Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/289146
Change subject: Compact language links: Delay loading of jquery.uls module
......................................................................
Compact language links: Delay loading of jquery.uls module
Load jquery.uls only when the trigger is clicked.
Reduces the initial footprint by 63.9 KB (uncompressed)
Bug: T135210
Change-Id: I972cb6ea1794485917ea530f7abe68bdddc2014f
---
M extension.json
M resources/js/ext.uls.compactlinks.js
2 files changed, 6 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/46/289146/1
diff --git a/extension.json b/extension.json
index 7fb2aa5..101d1f4 100644
--- a/extension.json
+++ b/extension.json
@@ -242,7 +242,6 @@
"styles": "css/ext.uls.compactlinks.less",
"dependencies": [
"es5-shim",
- "jquery.uls.compact",
"mediawiki.language",
"mediawiki.ui.button"
],
diff --git a/resources/js/ext.uls.compactlinks.js
b/resources/js/ext.uls.compactlinks.js
index e1e6c3a..b1168df 100644
--- a/resources/js/ext.uls.compactlinks.js
+++ b/resources/js/ext.uls.compactlinks.js
@@ -69,7 +69,7 @@
return;
}
- mw.loader.using( 'ext.uls.mediawiki' ).done( function
() {
+ mw.loader.using( 'ext.uls.init' ).done( function () {
// If we're only a bit beyond max, limit to 7
instead of 9.
// FIXME: This assumes the max is 9.
self.compactSize = ( self.listSize <= 12 ) ? 7
: max;
@@ -187,8 +187,11 @@
var self = this;
this.$trigger.one( 'click', function () {
- self.createSelector( self.$trigger );
- self.$trigger.click();
+ // Load the ULS now.
+ mw.loader.using( 'ext.uls.mediawiki', function
() {
+ self.createSelector( self.$trigger );
+ self.$trigger.click();
+ } );
} );
},
--
To view, visit https://gerrit.wikimedia.org/r/289146
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I972cb6ea1794485917ea530f7abe68bdddc2014f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
