jenkins-bot has submitted this change and it was merged.
Change subject: service::update: Tell pip to upgrade the packages if possible
......................................................................
service::update: Tell pip to upgrade the packages if possible
I was running into the problem of the eventbus proxy service not being
up and running after a vagrant git-update. It turns out that it was
failing because the requirements weren't updated, while the code was
counting on dependencies being there. To avoid that, pip needs also to
try to upgrade the dependencies when possible.
Change-Id: I63aabdf893f57656fb7c74762c25063cb748c5ac
---
M puppet/modules/service/manifests/gitupdate.pp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
BryanDavis: Looks good to me, approved
Ottomata: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/puppet/modules/service/manifests/gitupdate.pp
b/puppet/modules/service/manifests/gitupdate.pp
index c37de45..485d68e 100644
--- a/puppet/modules/service/manifests/gitupdate.pp
+++ b/puppet/modules/service/manifests/gitupdate.pp
@@ -87,7 +87,7 @@
$up_cmd = $type ? {
'php' => 'composer update --no-interaction --optimize-autoloader',
'nodejs' => 'sudo rm -rf node_modules && npm install --no-bin-links',
- 'python' => './virtualenv/bin/pip install -e .',
+ 'python' => './virtualenv/bin/pip install -Ue .',
default => 'invalid'
}
if $update and $up_cmd == 'invalid' {
--
To view, visit https://gerrit.wikimedia.org/r/288363
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I63aabdf893f57656fb7c74762c25063cb748c5ac
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: master
Gerrit-Owner: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: BryanDavis <bda...@wikimedia.org>
Gerrit-Reviewer: Dduvall <dduv...@wikimedia.org>
Gerrit-Reviewer: Ottomata <o...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
