jenkins-bot has submitted this change and it was merged. Change subject: Remove unused index feature from ClaimsChanger.js ......................................................................
Remove unused index feature from ClaimsChanger.js I found a single usage in https://www.wikidata.org/wiki/MediaWiki:Gadget-DuplicateReferences.js but not with this index feature. I do not know if other user-land code uses this. How to find out? Bug: T134887 Change-Id: I4eaa2c13a290d0b1901859a25f0ba9a17d308221 --- M view/resources/wikibase/entityChangers/ClaimsChanger.js M view/tests/qunit/wikibase/entityChangers/ClaimsChanger.tests.js 2 files changed, 13 insertions(+), 26 deletions(-) Approvals: Adrian Heine: Looks good to me, approved jenkins-bot: Verified diff --git a/view/resources/wikibase/entityChangers/ClaimsChanger.js b/view/resources/wikibase/entityChangers/ClaimsChanger.js index 22fd4b4..6a72434 100644 --- a/view/resources/wikibase/entityChangers/ClaimsChanger.js +++ b/view/resources/wikibase/entityChangers/ClaimsChanger.js @@ -93,21 +93,19 @@ /** * @param {wikibase.datamodel.Claim} claim - * @param {number} [index] * @return {jQuery.Promise} * Resolved parameters: * - {wikibase.datamodel.Claim} The saved claim * Rejected parameters: * - {wikibase.api.RepoApiError} */ - setClaim: function( claim, index ) { + setClaim: function( claim ) { var self = this, deferred = $.Deferred(); this._api.setClaim( this._claimSerializer.serialize( claim ), - this._revisionStore.getClaimRevision( claim.getGuid() ), - index + this._revisionStore.getClaimRevision( claim.getGuid() ) ) .done( function( result ) { var savedClaim = self._claimDeserializer.deserialize( result.claim ), @@ -129,21 +127,19 @@ /** * @param {wikibase.datamodel.Statement} statement - * @param {number} [index] * @return {Object} jQuery.Promise * Resolved parameters: * - {wikibase.datamodel.Statement} The saved statement * Rejected parameters: * - {wikibase.api.RepoApiError} */ - setStatement: function( statement, index ) { + setStatement: function( statement ) { var self = this, deferred = $.Deferred(); this._api.setClaim( this._statementSerializer.serialize( statement ), - this._revisionStore.getClaimRevision( statement.getClaim().getGuid() ), - index + this._revisionStore.getClaimRevision( statement.getClaim().getGuid() ) ) .done( function( result ) { var savedStatement = self._statementDeserializer.deserialize( result.claim ), diff --git a/view/tests/qunit/wikibase/entityChangers/ClaimsChanger.tests.js b/view/tests/qunit/wikibase/entityChangers/ClaimsChanger.tests.js index b7148e7..d3fe8e8 100644 --- a/view/tests/qunit/wikibase/entityChangers/ClaimsChanger.tests.js +++ b/view/tests/qunit/wikibase/entityChangers/ClaimsChanger.tests.js @@ -39,8 +39,7 @@ claimsChanger.removeStatement( new wb.datamodel.Statement( new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) - ) ), - 'index' + ) ) ); assert.ok( api.removeClaim.calledOnce ); @@ -70,8 +69,7 @@ claimsChanger.removeStatement( new wb.datamodel.Statement( new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) - ) ), - 'index' + ) ) ) .done( function() { assert.ok( true, 'removeStatement succeeded' ); @@ -107,8 +105,7 @@ claimsChanger.removeStatement( new wb.datamodel.Statement( new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) - ) ), - 'index' + ) ) ) .done( function() { assert.ok( false, 'removeStatement should have failed' ); @@ -141,8 +138,7 @@ ); claimsChanger.setClaim( - new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) ), - 'index' + new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) ) ); assert.ok( api.setClaim.calledOnce ); @@ -169,8 +165,7 @@ QUnit.stop(); claimsChanger.setClaim( - new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) ), - 'index' + new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) ) ) .done( function( savedClaim ) { assert.ok( @@ -209,8 +204,7 @@ QUnit.stop(); claimsChanger.setClaim( - new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) ), - 'index' + new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) ) ) .done( function( savedClaim ) { assert.ok( false, 'setClaim should have failed' ); @@ -247,8 +241,7 @@ claimsChanger.setStatement( new wb.datamodel.Statement( new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) - ) ), - 'index' + ) ) ); assert.ok( api.setClaim.calledOnce ); @@ -282,8 +275,7 @@ claimsChanger.setStatement( new wb.datamodel.Statement( new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) - ) ), - 'index' + ) ) ) .done( function( savedStatement ) { assert.ok( @@ -326,8 +318,7 @@ claimsChanger.setStatement( new wb.datamodel.Statement( new wb.datamodel.Claim( new wb.datamodel.PropertyNoValueSnak( 'P1' ) - ) ), - 'index' + ) ) ) .done( function( savedStatement ) { assert.ok( false, 'setStatement should have failed' ); -- To view, visit https://gerrit.wikimedia.org/r/287961 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4eaa2c13a290d0b1901859a25f0ba9a17d308221 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Adrian Heine <adrian.l...@wikimedia.de> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Hoo man <h...@online.de> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
