jenkins-bot has submitted this change and it was merged.
Change subject: Remove "Not logged in" from the personal URLs array
......................................................................
Remove "Not logged in" from the personal URLs array
The array of personal URLs should only contain links to the personal tools of
the
user. "Not logged in" is a status message, not a personal URL, so it should not
appear in that array. The status should instead be indicated to the user by the
skin itself in whatever way seems best for the skin in question.
The following patches depend on this one to reintroduce the message:
* Vector skin: Ic560d3fd
* Monobook skin: I7001e311
Bug: T121793
Bug: T127758
Change-Id: I5cfa9b4e2f4eb420d5fda6b1c6ce28926cb8e738
---
M includes/skins/SkinTemplate.php
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, but someone else must approve
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/skins/SkinTemplate.php b/includes/skins/SkinTemplate.php
index 10d9cb9..cefc5bc 100644
--- a/includes/skins/SkinTemplate.php
+++ b/includes/skins/SkinTemplate.php
@@ -695,11 +695,6 @@
// No need to show Talk and Contributions to anons if
they can't contribute!
if ( User::groupHasPermission( '*', 'edit' ) ) {
- // Show the text "Not logged in"
- $personal_urls['anonuserpage'] = [
- 'text' => $this->msg( 'notloggedin'
)->text()
- ];
-
// Because of caching, we can't link directly
to the IP talk and
// contributions pages. Instead we use the
special page shortcuts
// (which work correctly regardless of
caching). This means we can't
--
To view, visit https://gerrit.wikimedia.org/r/273108
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5cfa9b4e2f4eb420d5fda6b1c6ce28926cb8e738
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Foxtrott <s7ep...@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Foxtrott <s7ep...@gmail.com>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: TTO <at.li...@live.com.au>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
