MaxSem has submitted this change and it was merged.
Change subject: Improve diff docs
......................................................................
Improve diff docs
Change-Id: I42332051f6f1b94f459b06d6c69625bc2a1fa9cf
---
M includes/diff/DiffEngine.php
1 file changed, 12 insertions(+), 2 deletions(-)
Approvals:
MaxSem: Looks good to me, approved
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/diff/DiffEngine.php b/includes/diff/DiffEngine.php
index 75e8791..1853b86 100644
--- a/includes/diff/DiffEngine.php
+++ b/includes/diff/DiffEngine.php
@@ -67,6 +67,8 @@
}
/**
+ * Performs diff
+ *
* @param string[] $from_lines
* @param string[] $to_lines
*
@@ -138,8 +140,12 @@
* to be the "change".
*
* This is extracted verbatim from analyze.c (GNU diffutils-2.7).
+ *
+ * @param string[] $lines
+ * @param string[] $changed
+ * @param string[] $other_changed
*/
- private function shiftBoundaries( $lines, &$changed, $other_changed ) {
+ private function shiftBoundaries( array $lines, array &$changed, array
$other_changed ) {
$i = 0;
$j = 0;
@@ -256,7 +262,11 @@
}
}
- protected function diffInternal( /*array*/ $from, /*array*/ $to ) {
+ /**
+ * @param string[] $from
+ * @param string[] $to
+ */
+ protected function diffInternal( array $from, array $to ) {
// remember initial lengths
$m = count( $from );
$n = count( $to );
--
To view, visit https://gerrit.wikimedia.org/r/285566
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42332051f6f1b94f459b06d6c69625bc2a1fa9cf
Gerrit-PatchSet: 8
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
