Thcipriani has submitted this change and it was merged.

Change subject: Fix central logout
......................................................................


Fix central logout

Fixes I995bb7ee16abe94c4ffbff0330a1acb2721115cd which pushed creating
the centraluser from the local user (for central token reset) after
the point where the local user is logged out.

Bug: T135525
Bug: T92357
Change-Id: I1a174f76d343e7e6a26ba5e5df7c5edda21a3c01
Co-Authored-By: Anomie <bjor...@wikimedia.org>
(cherry picked from commit fda5a85d3bfb4a2f83304b558686cc877319610b)
---
M includes/CentralAuthHooks.php
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Thcipriani: Verified; Looks good to me, approved



diff --git a/includes/CentralAuthHooks.php b/includes/CentralAuthHooks.php
index 36d37f2..76e3352 100644
--- a/includes/CentralAuthHooks.php
+++ b/includes/CentralAuthHooks.php
@@ -706,8 +706,9 @@
                        return true;
                }
 
-               DeferredUpdates::addCallableUpdate( function() use ( $user ) {
-                       $centralUser = CentralAuthUser::getMasterInstance( 
$user );
+               $username = $user->getName();
+               DeferredUpdates::addCallableUpdate( function() use ( $username 
) {
+                       $centralUser = 
CentralAuthUser::getMasterInstanceByName( $username );
                        if ( $centralUser->exists() ) {
                                $centralUser->resetAuthToken();
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/289431
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1a174f76d343e7e6a26ba5e5df7c5edda21a3c01
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: wmf/1.28.0-wmf.2
Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org>
Gerrit-Reviewer: Thcipriani <tcipri...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to