TheDJ has uploaded a new change for review.
https://gerrit.wikimedia.org/r/289573
Change subject: Allow mwEmbed to pick up classes from media element
......................................................................
Allow mwEmbed to pick up classes from media element
This let's the player pick up classes passed by the audio and video
tags. We need to make sure that we don't also pick up the skin
classname, because that's not how MwEmbed works.
Bug: T135537
Change-Id: I112d2b54407e1f61cb67a04e7d67df42aff4ab67
---
M MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
1 file changed, 5 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler
refs/changes/73/289573/1
diff --git a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
index a9aea2b..13a815b 100644
--- a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
+++ b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedPlayer.js
@@ -18,6 +18,9 @@
// id: Auto-populated if unset
"id" : null,
+ // class: Auto-populated if unset
+ "class": null,
+
// Width: alternate to "style" to set player width
"width" : null,
@@ -1177,7 +1180,8 @@
// build the interface wrapper
this.$interface = $( this ).wrap(
$('<div />')
- .addClass( 'mwPlayerContainer ' +
this.controlBuilder.playerClass )
+ .addClass( 'mwPlayerContainer ' + this[
'class' ] + ' ' + this.controlBuilder.playerClass )
+ .removeClass( this.skinName )
.append(
$('<div />').addClass(
'videoHolder' )
)
--
To view, visit https://gerrit.wikimedia.org/r/289573
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I112d2b54407e1f61cb67a04e7d67df42aff4ab67
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
