Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/289668
Change subject: build: Enforce stylelints on fonts
......................................................................
build: Enforce stylelints on fonts
* Font families should be quoted unless keywords (''Times'' not 'Times')
* Font weights should be named where possible ('bold' not '400')
Change-Id: I20194c2998efb71db4da5ea79234a81dc90b55ea
---
M .stylelintrc
M mw-config/config-cc.css
M resources/src/mediawiki.skinning/elements.css
M resources/src/mediawiki.special/mediawiki.special.userlogin.signup.css
4 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/68/289668/1
diff --git a/.stylelintrc b/.stylelintrc
index ca0af95..e8e1567 100644
--- a/.stylelintrc
+++ b/.stylelintrc
@@ -9,5 +9,8 @@
"declaration-bang-space-before": [ "always" ],
"declaration-colon-space-after": [ "always" ],
"declaration-colon-space-before": [ "never" ],
+
+ "font-family-name-quotes": [ "single-unless-keyword" ],
+ "font-weight-notation": [ "named-where-possible" ]
}
}
diff --git a/mw-config/config-cc.css b/mw-config/config-cc.css
index 29dc80c..f9c6117 100644
--- a/mw-config/config-cc.css
+++ b/mw-config/config-cc.css
@@ -5,7 +5,7 @@
body {
margin: 0;
background: #eee;
- font-family: Verdana;
+ font-family: 'Verdana';
color: #333;
}
diff --git a/resources/src/mediawiki.skinning/elements.css
b/resources/src/mediawiki.skinning/elements.css
index f267784..7b0b071 100644
--- a/resources/src/mediawiki.skinning/elements.css
+++ b/resources/src/mediawiki.skinning/elements.css
@@ -195,7 +195,7 @@
* Some browsers will render the monospace text too small, namely
Firefox, Chrome and Safari.
* Specifying any valid, second value will trigger correct behavior
without forcing a different font.
*/
- font-family: monospace, Courier;
+ font-family: monospace, 'Courier';
}
code {
diff --git
a/resources/src/mediawiki.special/mediawiki.special.userlogin.signup.css
b/resources/src/mediawiki.special/mediawiki.special.userlogin.signup.css
index 0998d4c..87cdb02 100644
--- a/resources/src/mediawiki.special/mediawiki.special.userlogin.signup.css
+++ b/resources/src/mediawiki.special/mediawiki.special.userlogin.signup.css
@@ -45,7 +45,7 @@
margin: 0;
padding: 0;
color: #252525;
- font-family: "Linux Libertine", Georgia, Times, serif;
+ font-family: 'Linux Libertine', 'Georgia', 'Times', serif;
font-weight: normal;
font-size: 2.2em;
line-height: 1.2;
--
To view, visit https://gerrit.wikimedia.org/r/289668
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I20194c2998efb71db4da5ea79234a81dc90b55ea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
