[MediaWiki-commits] [Gerrit] Minor post-API change patch cleanup - change (apps...wikipedia)

[Mholloway (Code Review)]

Mholloway has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/289776

Change subject: Minor post-API change patch cleanup
......................................................................

Minor post-API change patch cleanup

-Remove methods where implementation is identical to that in superclass
-Rename flag param from 'i' to 'flags' in Parcelable.writeToParcel impl's
-Remove unused method

Change-Id: I57f775ce0e74c437c7a8a663b2bfc1a2a8bb2622
---
M app/src/main/java/org/wikipedia/createaccount/CreateAccountResult.java
M app/src/main/java/org/wikipedia/createaccount/CreateAccountSuccessResult.java
M 
app/src/main/java/org/wikipedia/createaccount/authmanager/AMCreateAccountInfoResult.java
M 
app/src/main/java/org/wikipedia/createaccount/authmanager/AMCreateAccountResult.java
M 
app/src/main/java/org/wikipedia/createaccount/authmanager/AMCreateAccountSuccessResult.java
5 files changed, 6 insertions(+), 21 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/76/289776/1

diff --git 
a/app/src/main/java/org/wikipedia/createaccount/CreateAccountResult.java 
b/app/src/main/java/org/wikipedia/createaccount/CreateAccountResult.java
index 96646b8..401ae02 100644
--- a/app/src/main/java/org/wikipedia/createaccount/CreateAccountResult.java
+++ b/app/src/main/java/org/wikipedia/createaccount/CreateAccountResult.java
@@ -15,7 +15,7 @@
     }
 
     @Override
-    public void writeToParcel(Parcel parcel, int i) {
+    public void writeToParcel(Parcel parcel, int flags) {
         parcel.writeString(result);
     }
 
diff --git 
a/app/src/main/java/org/wikipedia/createaccount/CreateAccountSuccessResult.java 
b/app/src/main/java/org/wikipedia/createaccount/CreateAccountSuccessResult.java
index 5e136f4..e6ad938 100644
--- 
a/app/src/main/java/org/wikipedia/createaccount/CreateAccountSuccessResult.java
+++ 
b/app/src/main/java/org/wikipedia/createaccount/CreateAccountSuccessResult.java
@@ -16,13 +16,8 @@
     }
 
     @Override
-    public int describeContents() {
-        return 0;
-    }
-
-    @Override
-    public void writeToParcel(Parcel parcel, int i) {
-        super.writeToParcel(parcel, i);
+    public void writeToParcel(Parcel parcel, int flags) {
+        super.writeToParcel(parcel, flags);
         parcel.writeString(username);
     }
 
diff --git 
a/app/src/main/java/org/wikipedia/createaccount/authmanager/AMCreateAccountInfoResult.java
 
b/app/src/main/java/org/wikipedia/createaccount/authmanager/AMCreateAccountInfoResult.java
index 0514872..869dd23 100644
--- 
a/app/src/main/java/org/wikipedia/createaccount/authmanager/AMCreateAccountInfoResult.java
+++ 
b/app/src/main/java/org/wikipedia/createaccount/authmanager/AMCreateAccountInfoResult.java
@@ -25,9 +25,4 @@
     public String getCaptchaId() {
         return captchaId;
     }
-
-    @Nullable
-    public List<String> getSessionCookie() {
-        return sessionCookie;
-    }
 }
diff --git 
a/app/src/main/java/org/wikipedia/createaccount/authmanager/AMCreateAccountResult.java
 
b/app/src/main/java/org/wikipedia/createaccount/authmanager/AMCreateAccountResult.java
index 31bc2c2..dc90e79 100644
--- 
a/app/src/main/java/org/wikipedia/createaccount/authmanager/AMCreateAccountResult.java
+++ 
b/app/src/main/java/org/wikipedia/createaccount/authmanager/AMCreateAccountResult.java
@@ -26,7 +26,7 @@
     }
 
     @Override
-    public void writeToParcel(Parcel parcel, int i) {
+    public void writeToParcel(Parcel parcel, int flags) {
         parcel.writeString(status);
         parcel.writeString(message);
     }
diff --git 
a/app/src/main/java/org/wikipedia/createaccount/authmanager/AMCreateAccountSuccessResult.java
 
b/app/src/main/java/org/wikipedia/createaccount/authmanager/AMCreateAccountSuccessResult.java
index 903bc7a..8340114 100644
--- 
a/app/src/main/java/org/wikipedia/createaccount/authmanager/AMCreateAccountSuccessResult.java
+++ 
b/app/src/main/java/org/wikipedia/createaccount/authmanager/AMCreateAccountSuccessResult.java
@@ -16,13 +16,8 @@
     }
 
     @Override
-    public int describeContents() {
-        return 0;
-    }
-
-    @Override
-    public void writeToParcel(Parcel parcel, int i) {
-        super.writeToParcel(parcel, i);
+    public void writeToParcel(Parcel parcel, int flags) {
+        super.writeToParcel(parcel, flags);
         parcel.writeString(username);
     }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/289776
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I57f775ce0e74c437c7a8a663b2bfc1a2a8bb2622
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <mhollo...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits