Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/289781
Change subject: Remove 'noclasses' from Linker::linkKnown() defaults
......................................................................
Remove 'noclasses' from Linker::linkKnown() defaults
The intention for Linker::linkKnown() was to be used when the caller had
already preloaded the target's existence ('known') and called
Linker::getLinkColour() directly ('noclasses'). However, nearly all
usage of linkKnown() only did the first part, and not the latter.
So do what people actually ended up using the function for, and remove
'noclasses' from the default parameters. As long as the target the link
is being created for is already in LinkCache, this shouldn't cause any
extra database queries.
Change-Id: Ia5a4c2f18ec780627146617a1498bd04fcfbb3ee
---
M includes/DummyLinker.php
M includes/Linker.php
M tests/parser/parserTests.txt
3 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/81/289781/1
diff --git a/includes/DummyLinker.php b/includes/DummyLinker.php
index 6545c4a..d9330ee 100644
--- a/includes/DummyLinker.php
+++ b/includes/DummyLinker.php
@@ -72,7 +72,7 @@
$html = null,
$customAttribs = [],
$query = [],
- $options = [ 'known', 'noclasses' ]
+ $options = [ 'known' ]
) {
return Linker::linkKnown(
$target,
diff --git a/includes/Linker.php b/includes/Linker.php
index 6a869dd..20dc9b2 100644
--- a/includes/Linker.php
+++ b/includes/Linker.php
@@ -269,7 +269,7 @@
*/
public static function linkKnown(
$target, $html = null, $customAttribs = [],
- $query = [], $options = [ 'known', 'noclasses' ]
+ $query = [], $options = [ 'known' ]
) {
return self::link( $target, $html, $customAttribs, $query,
$options );
}
diff --git a/tests/parser/parserTests.txt b/tests/parser/parserTests.txt
index 7051b4f..930c879 100644
--- a/tests/parser/parserTests.txt
+++ b/tests/parser/parserTests.txt
@@ -13944,7 +13944,7 @@
!! wikitext
[[Image:Barfoo.jpg]]
!! html/php
-<p><a href="/wiki/File:Barfoo.jpg" title="File:Barfoo.jpg">File:Barfoo.jpg</a>
+<p><a href="/wiki/File:Barfoo.jpg" class="mw-redirect"
title="File:Barfoo.jpg">File:Barfoo.jpg</a>
</p>
!! end
--
To view, visit https://gerrit.wikimedia.org/r/289781
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5a4c2f18ec780627146617a1498bd04fcfbb3ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
