jenkins-bot has submitted this change and it was merged.
Change subject: Reset title related services for asserting prefixed special
page names
......................................................................
Reset title related services for asserting prefixed special page names
In order to makes the tests pass on non-English wikis.
Change-Id: Iaa7387815108d0c3b70ad52e4f0b397197ed30bf
---
M repo/tests/phpunit/includes/Specials/SpecialListDatatypesTest.php
M repo/tests/phpunit/includes/View/RepoSpecialPageLinkerTest.php
2 files changed, 33 insertions(+), 0 deletions(-)
Approvals:
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/tests/phpunit/includes/Specials/SpecialListDatatypesTest.php
b/repo/tests/phpunit/includes/Specials/SpecialListDatatypesTest.php
index 911eb6e..8a428b7 100644
--- a/repo/tests/phpunit/includes/Specials/SpecialListDatatypesTest.php
+++ b/repo/tests/phpunit/includes/Specials/SpecialListDatatypesTest.php
@@ -3,6 +3,7 @@
namespace Wikibase\Repo\Tests\Specials;
use Language;
+use MediaWiki\MediaWikiServices;
use SpecialPageTestBase;
use Wikibase\Repo\Specials\SpecialListDatatypes;
@@ -26,6 +27,19 @@
$this->setMwGlobals( array(
'wgContLang' => Language::factory( 'qqx' )
) );
+ $services = MediaWikiServices::getInstance();
+ $services->resetServiceForTesting( 'TitleFormatter' );
+ $services->resetServiceForTesting( 'TitleParser' );
+ $services->resetServiceForTesting( '_MediaWikiTitleCodec' );
+ }
+
+ protected function tearDown() {
+ parent::tearDown();
+
+ $services = MediaWikiServices::getInstance();
+ $services->resetServiceForTesting( 'TitleFormatter' );
+ $services->resetServiceForTesting( 'TitleParser' );
+ $services->resetServiceForTesting( '_MediaWikiTitleCodec' );
}
protected function newSpecialPage() {
diff --git a/repo/tests/phpunit/includes/View/RepoSpecialPageLinkerTest.php
b/repo/tests/phpunit/includes/View/RepoSpecialPageLinkerTest.php
index 18002e3..b4ecd8c 100644
--- a/repo/tests/phpunit/includes/View/RepoSpecialPageLinkerTest.php
+++ b/repo/tests/phpunit/includes/View/RepoSpecialPageLinkerTest.php
@@ -3,6 +3,7 @@
namespace Wikibase\Test;
use MediaWikiLangTestCase;
+use MediaWiki\MediaWikiServices;
use Wikibase\Repo\View\RepoSpecialPageLinker;
/**
@@ -15,6 +16,24 @@
*/
class RepoSpecialPageLinkerTest extends MediaWikiLangTestCase {
+ protected function setUp() {
+ parent::setUp();
+
+ $services = MediaWikiServices::getInstance();
+ $services->resetServiceForTesting( 'TitleFormatter' );
+ $services->resetServiceForTesting( 'TitleParser' );
+ $services->resetServiceForTesting( '_MediaWikiTitleCodec' );
+ }
+
+ protected function tearDown() {
+ parent::tearDown();
+
+ $services = MediaWikiServices::getInstance();
+ $services->resetServiceForTesting( 'TitleFormatter' );
+ $services->resetServiceForTesting( 'TitleParser' );
+ $services->resetServiceForTesting( '_MediaWikiTitleCodec' );
+ }
+
/**
* @dataProvider getLinkProvider
*
--
To view, visit https://gerrit.wikimedia.org/r/289793
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa7387815108d0c3b70ad52e4f0b397197ed30bf
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <h...@online.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: JanZerebecki <jan.wikime...@zerebecki.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
