Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/289803

Change subject: Don't show tab preference dialog again if it's already been 
shown
......................................................................

Don't show tab preference dialog again if it's already been shown

Bug: T135534
Change-Id: Ifecac607acccc0e18e61b07e8456566d4671aa1b
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
2 files changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/03/289803/1

diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index f339c6b..53cae13 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -823,6 +823,7 @@
 
                                                // Duplicate of this code in 
ve.init.mw.DesktopArticleTarget.js
                                                if ( $( '#ca-edit' ).hasClass( 
'visualeditor-showtabdialog' ) ) {
+                                                       $( '#ca-edit' 
).removeClass( 'visualeditor-showtabdialog' );
                                                        // Set up a temporary 
window manager
                                                        windowManager = new 
OO.ui.WindowManager();
                                                        $( 'body' ).append( 
windowManager.$element );
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
index 1debd0b..5a4e023 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
@@ -266,6 +266,7 @@
 
        // Duplicate of this code in ve.init.mw.DesktopArticleTarget.init.js
        if ( $( '#ca-edit' ).hasClass( 'visualeditor-showtabdialog' ) ) {
+               $( '#ca-edit' ).removeClass( 'visualeditor-showtabdialog' );
                // Set up a temporary window manager
                windowManager = new OO.ui.WindowManager();
                $( 'body' ).append( windowManager.$element );

-- 
To view, visit https://gerrit.wikimedia.org/r/289803
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifecac607acccc0e18e61b07e8456566d4671aa1b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to