Dzahn has uploaded a new change for review.
https://gerrit.wikimedia.org/r/289980
Change subject: kafka: fix lint warnings
......................................................................
kafka: fix lint warnings
Change-Id: I7acf023af335f99acd8bddd9c7ed528439909e1d
---
M manifests/server/jmxtrans.pp
M manifests/server/monitoring.pp
2 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet/kafka
refs/changes/80/289980/1
diff --git a/manifests/server/jmxtrans.pp b/manifests/server/jmxtrans.pp
index fc539c9..da5645b 100644
--- a/manifests/server/jmxtrans.pp
+++ b/manifests/server/jmxtrans.pp
@@ -46,11 +46,11 @@
# query for metrics from Kafka's JVM
jmxtrans::metrics::jvm { $jmx:
- ganglia => $ganglia,
- graphite => $graphite,
- statsd => $statsd,
- outfile => $outfile,
- group_prefix => $group_prefix,
+ ganglia => $ganglia,
+ graphite => $graphite,
+ statsd => $statsd,
+ outfile => $outfile,
+ group_prefix => $group_prefix,
}
# DRY up some often used JMX attributes.
diff --git a/manifests/server/monitoring.pp b/manifests/server/monitoring.pp
index 352093f..4983893 100644
--- a/manifests/server/monitoring.pp
+++ b/manifests/server/monitoring.pp
@@ -55,6 +55,10 @@
# Alert if any Kafka Broker replica lag is too high
monitoring::graphite_threshold { 'kafka-broker-Replica-MaxLag':
+ # This check is too noisy because of
+ # https://phabricator.wikimedia.org/T121407.
+ # TODO: Re-enable after 0.9 upgrade.
+ ensure => 'absent',
description => 'Kafka Broker Replica Max Lag',
metric =>
"${group_prefix}kafka.${graphite_broker_key}.kafka.server.ReplicaFetcherManager.MaxLag.Value",
# As of 2014-02 replag could catch up at more than 1000 msgs / sec,
@@ -69,10 +73,6 @@
percentage => 50,
require => Class['::kafka::server::jmxtrans'],
group => $nagios_servicegroup,
- # This check is too noisy because of
- # https://phabricator.wikimedia.org/T121407.
- # TODO: Re-enable after 0.9 upgrade.
- ensure => 'absent',
}
# monitor disk statistics
--
To view, visit https://gerrit.wikimedia.org/r/289980
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7acf023af335f99acd8bddd9c7ed528439909e1d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet/kafka
Gerrit-Branch: master
Gerrit-Owner: Dzahn <dz...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
