Florianschmidtwelzow has uploaded a new change for review. https://gerrit.wikimedia.org/r/290050
Change subject: Special:UserLogin: Consolidate create account buttons ...................................................................... Special:UserLogin: Consolidate create account buttons When logged in and not logged in. Both now shares the same styles and DOM structure. The differences: * When logged in, you don't get a "Don't have an account?" message * When logged in, the button's label is "Create another account" instead of "Join {wikiname}" Bug: T135925 Change-Id: I90c7a1288af927a03da3ccf9499f625935742125 --- M includes/specialpage/LoginSignupSpecialPage.php 1 file changed, 18 insertions(+), 30 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/50/290050/1 diff --git a/includes/specialpage/LoginSignupSpecialPage.php b/includes/specialpage/LoginSignupSpecialPage.php index 0e4252c..732d28a 100644 --- a/includes/specialpage/LoginSignupSpecialPage.php +++ b/includes/specialpage/LoginSignupSpecialPage.php @@ -652,37 +652,25 @@ if ( $wgLoginLanguageSelector && $this->mLanguage ) { $linkq .= '&uselang=' . $this->mLanguage; } - $createOrLoginHref = $linkTitle->getLocalURL( $linkq ); - if ( $this->getUser()->isLoggedIn() ) { - $createOrLoginHtml = Html::rawElement( 'div', - [ 'class' => 'mw-ui-vform-field' ], - Html::element( 'a', - [ - 'id' => 'mw-createaccount-join', - 'href' => $createOrLoginHref, - // put right after all auth inputs in the tab order - 'tabindex' => 100, - ], - $this->msg( 'userlogin-createanother' )->escaped() - ) - ); - } else { - $createOrLoginHtml = Html::rawElement( 'div', - [ 'id' => 'mw-createaccount-cta', - 'class' => 'mw-ui-vform-field' ], - $this->msg( 'userlogin-noaccount' )->escaped() - . Html::element( 'a', - [ - 'id' => 'mw-createaccount-join', - 'href' => $createOrLoginHref, - 'class' => 'mw-ui-button', - 'tabindex' => 100, - ], - $this->msg( 'userlogin-joinproject' )->escaped() - ) - ); - } + $createOrLoginHtml = Html::rawElement( 'div', + [ 'id' => 'mw-createaccount-cta', + 'class' => 'mw-ui-vform-field' ], + ( $this->getUser()->isLoggedIn() ? '' : $this->msg( 'userlogin-noaccount' )->escaped() ) + . Html::element( 'a', + [ + 'id' => 'mw-createaccount-join', + 'href' => $linkTitle->getLocalURL( $linkq ), + 'class' => 'mw-ui-button', + 'tabindex' => 100, + ], + $this->msg( + ( $this->getUser()->isLoggedIn() ? + 'userlogin-createanother' : + 'userlogin-joinproject' + ) )->escaped() + ) + ); $form->addFooterText( $createOrLoginHtml ); } } -- To view, visit https://gerrit.wikimedia.org/r/290050 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I90c7a1288af927a03da3ccf9499f625935742125 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits