TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/290067
Change subject: Avoid flash of content when hiding editHelp and the pipe separator ...................................................................... Avoid flash of content when hiding editHelp and the pipe separator Bug: T120408 Change-Id: I651ea3d2b891ce347a51be9b3bc3e34351bc53dc --- M WikiEditor.hooks.php M extension.json M modules/ext.wikiEditor.less 3 files changed, 7 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor refs/changes/67/290067/1 diff --git a/WikiEditor.hooks.php b/WikiEditor.hooks.php index b9c4660..f18a4ed 100644 --- a/WikiEditor.hooks.php +++ b/WikiEditor.hooks.php @@ -183,6 +183,8 @@ return true; } + $outputPage->addModuleStyles( 'ext.wikiEditor.styles' ); + // Add modules for enabled features foreach ( self::$features as $name => $feature ) { if ( !self::isEnabled( $name ) ) { diff --git a/extension.json b/extension.json index dbd05d6..d0491fe 100644 --- a/extension.json +++ b/extension.json @@ -329,12 +329,15 @@ "ext.wikiEditor": { "group": "ext.wikiEditor", "scripts": "ext.wikiEditor.js", - "styles": "ext.wikiEditor.less", "dependencies": [ "jquery.wikiEditor", "mediawiki.user" ] }, + "ext.wikiEditor.styles": { + "group": "ext.wikiEditor", + "styles": "ext.wikiEditor.less" + }, "ext.wikiEditor.dialogs": { "group": "ext.wikiEditor", "scripts": "ext.wikiEditor.dialogs.js", diff --git a/modules/ext.wikiEditor.less b/modules/ext.wikiEditor.less index 0163242..9d3bb25 100644 --- a/modules/ext.wikiEditor.less +++ b/modules/ext.wikiEditor.less @@ -3,7 +3,7 @@ */ /* Hide vanilla MediaWiki's "Editing help" link, as we provide it in the toolbar */ -.editButtons { +.client-js .editButtons { .editHelp, .mw-editButtons-pipe-separator { display: none; -- To view, visit https://gerrit.wikimedia.org/r/290067 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I651ea3d2b891ce347a51be9b3bc3e34351bc53dc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikiEditor Gerrit-Branch: master Gerrit-Owner: TheDJ <hartman.w...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits