Glaisher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/290073
Change subject: Show ParserOutput warning instead of on the actual page output
for ignored display titles
......................................................................
Show ParserOutput warning instead of on the actual page output for ignored
display titles
Ignored restricted DISPLAYTITLE warning isn't really relevant for the casual
reader
so don't show it in the page output. Instead show it above the edit box.
Bug: T135949
Change-Id: I009dd865bec7b6e3a7492c49db97074483f93ee4
---
M includes/parser/CoreParserFunctions.php
M languages/i18n/qqq.json
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/73/290073/1
diff --git a/includes/parser/CoreParserFunctions.php
b/includes/parser/CoreParserFunctions.php
index d8bd42e..1718557 100644
--- a/includes/parser/CoreParserFunctions.php
+++ b/includes/parser/CoreParserFunctions.php
@@ -460,14 +460,14 @@
return '';
}
} else {
- $parser->addTrackingCategory(
'restricted-displaytitle-ignored' );
$converter =
$parser->getConverterLanguage()->getConverter();
- return '<span class="error">' .
+ $parser->getOutput()->addWarning(
wfMessage( 'restricted-displaytitle',
// Message should be parsed, but this
param should only be escaped.
$converter->markNoConversion(
wfEscapeWikiText( $text ) )
- )->inContentLanguage()->text() .
- '</span>';
+ )->text()
+ );
+ $parser->addTrackingCategory(
'restricted-displaytitle-ignored' );
}
}
diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json
index 5e07644..24f1c9e 100644
--- a/languages/i18n/qqq.json
+++ b/languages/i18n/qqq.json
@@ -3711,7 +3711,7 @@
"timezone-local": "Label to indicate that a time is in the user's local
timezone.\n{{Identical|Local}}",
"duplicate-defaultsort": "See definition of [[w:Sorting|sort key]] on
Wikipedia. Parameters:\n* $1 - old default sort key\n* $2 - new default sort
key",
"duplicate-displaytitle": "Warning shown when a page has its display
title set multiple times. Parameters:\n* $1 - old display title\n* $2 - new
display title",
- "restricted-displaytitle": "Warning shown a display title is ignored
because it is not equivalent to its actual title. Parameters:\n* $1 - the
ignored display title",
+ "restricted-displaytitle": "Warning shown when a display title is
ignored because it is not equivalent to its actual title. Parameters:\n* $1 -
the ignored display title",
"invalid-indicator-name": "Warning shown when the
[https://www.mediawiki.org/wiki/Help:Page_status_indicators <indicator
name=\"''unique-identifier''\">''content''</indicator>] parser tag is used
incorrectly.",
"version": "{{doc-special|Version}}\n{{Identical|Version}}",
"version-summary": "{{doc-specialpagesummary|version}}",
--
To view, visit https://gerrit.wikimedia.org/r/290073
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I009dd865bec7b6e3a7492c49db97074483f93ee4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Glaisher <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
