Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/290223
Change subject: Stylelint: Add function rules and whitespace inside brackets
......................................................................
Stylelint: Add function rules and whitespace inside brackets
Change-Id: Idfc53aee2da50f31ddd9f26daaaa968c583069c1
---
M .stylelintrc
M minerva.less/minerva.mixins.less
M minerva.less/minerva.variables.less
M resources/mobile.ajax/spinner.less
M resources/mobile.backtotop/backtotop.less
M resources/mobile.buttonWithSpinner/buttonWithSpinner.less
M resources/mobile.categories.overlays/categories.less
M resources/mobile.contentOverlays/tutorials.less
M resources/mobile.drawers/drawer.less
M resources/mobile.editor.common/editor.less
M resources/mobile.editor.ve/VisualEditorOverlay.less
M resources/mobile.gallery/gallery.less
M resources/mobile.issues/issues.less
M resources/mobile.languages.structured/LanguageOverlay.less
M resources/mobile.mainMenu/mainmenu.less
M resources/mobile.notifications.overlay/NotificationsOverlay.less
M resources/mobile.overlays/Overlay.less
M resources/mobile.pagelist.styles/pagelist.less
M resources/mobile.pagesummary.styles/pagesummary.less
M resources/mobile.references/references.less
M resources/mobile.search/SearchOverlay.less
M resources/mobile.special.mobilediff.styles/icons.less
M resources/mobile.special.mobilediff.styles/mobilediff.less
M resources/mobile.special.uploads.styles/uploads.less
M resources/mobile.toast/toast.less
M resources/mobile.toc/toc.less
M resources/mobile.watchstar/watchstar.less
M resources/skins.minerva.base.styles/common.less
M resources/skins.minerva.base.styles/icons.less
M resources/skins.minerva.base.styles/images.less
M resources/skins.minerva.base.styles/pageactions.less
M resources/skins.minerva.base.styles/ui.less
M resources/skins.minerva.beta.styles/pageactions.less
M resources/skins.minerva.content.styles/hacks.less
M resources/skins.minerva.content.styles/main.less
M resources/skins.minerva.special.userlogin.styles/userlogin.less
M resources/skins.minerva.special.watchlist.styles/specialWatchlist.less
M resources/skins.minerva.tablet.styles/common.less
M resources/skins.minerva.tablet.styles/hacks.less
M resources/skins.minerva.talk/talk.less
40 files changed, 103 insertions(+), 91 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/23/290223/1
diff --git a/.stylelintrc b/.stylelintrc
index 47048b4..8c4e88a 100644
--- a/.stylelintrc
+++ b/.stylelintrc
@@ -13,7 +13,19 @@
"font-family-name-quotes": [ "single-unless-keyword" ],
"font-weight-notation": [ "named-where-possible" ],
+ "function-calc-no-unspaced-operator": true,
+ "function-comma-newline-after": "never-multi-line",
+ "function-comma-newline-before": "never-multi-line",
+ "function-comma-space-after": [ "always" ],
+ "function-comma-space-before": [ "never" ],
+ "function-parentheses-newline-inside": [ "never-multi-line" ],
+ "function-parentheses-space-inside": [ "always" ],
+ "function-url-quotes": [ "none" ],
+ "function-whitespace-after": [ "always" ],
+
"string-no-newline": true,
- "string-quotes": [ "single" ]
+ "string-quotes": [ "single" ],
+
+ "media-query-parentheses-space-inside": [ "always" ]
}
}
diff --git a/minerva.less/minerva.mixins.less b/minerva.less/minerva.mixins.less
index 06f5f29..e885e30 100644
--- a/minerva.less/minerva.mixins.less
+++ b/minerva.less/minerva.mixins.less
@@ -8,7 +8,7 @@
.m-background-image( @url ) {
&:after,
&:before {
- .background-image(@url)
+ .background-image( @url )
}
}
diff --git a/minerva.less/minerva.variables.less
b/minerva.less/minerva.variables.less
index 07f1d66..8638fb5 100644
--- a/minerva.less/minerva.variables.less
+++ b/minerva.less/minerva.variables.less
@@ -43,7 +43,7 @@
// colors
@chromeColor: #f2f2f2;
@chromeContentSeparator: @colorGray13;
-@semiTransparent: rgba(255, 255, 255, .8);
+@semiTransparent: rgba( 255, 255, 255, .8 );
// note this is also used for red links
@redBase: @colorErrorText;
@colorTutorial: #2e76ff;
diff --git a/resources/mobile.ajax/spinner.less
b/resources/mobile.ajax/spinner.less
index 5a76a5e..2410077 100644
--- a/resources/mobile.ajax/spinner.less
+++ b/resources/mobile.ajax/spinner.less
@@ -5,11 +5,11 @@
// FIXME: Standardise on a loading class (update ConfirmEdit extension)
.fancycaptcha-reload-loading,
.mw-ui-icon-spinner {
- .m-background-image('ajax-loader.gif');
+ .m-background-image( 'ajax-loader.gif' );
}
.mw-ui-icon-refresh {
- .m-background-image('refresh.png');
+ .m-background-image( 'refresh.png' );
}
// Asynchronous loading
diff --git a/resources/mobile.backtotop/backtotop.less
b/resources/mobile.backtotop/backtotop.less
index 73db810..7528fce 100644
--- a/resources/mobile.backtotop/backtotop.less
+++ b/resources/mobile.backtotop/backtotop.less
@@ -30,7 +30,7 @@
/* center arrow in RTL wikis */
.rtl > & .arrow-up {
- transform: translate(50%, -50%);
+ transform: translate( 50%, -50% );
}
>.arrow-up {
@@ -42,6 +42,6 @@
position: absolute;
top: 50%;
left: 50%;
- transform: translate(-50%, -50%);
+ transform: translate( -50%, -50% );
}
}
diff --git a/resources/mobile.buttonWithSpinner/buttonWithSpinner.less
b/resources/mobile.buttonWithSpinner/buttonWithSpinner.less
index 6bf6133..109df07 100644
--- a/resources/mobile.buttonWithSpinner/buttonWithSpinner.less
+++ b/resources/mobile.buttonWithSpinner/buttonWithSpinner.less
@@ -1,8 +1,8 @@
@import 'minerva.mixins';
.oo-ui-indicator-spinner {
- .background-image('ajax-loader.gif');
- .background-size(100%, 100%);
+ .background-image( 'ajax-loader.gif' );
+ .background-size( 100%, 100% );
margin-left: 0 !important;
margin-right: 0 !important;
}
diff --git a/resources/mobile.categories.overlays/categories.less
b/resources/mobile.categories.overlays/categories.less
index e928f7a..96004ea 100644
--- a/resources/mobile.categories.overlays/categories.less
+++ b/resources/mobile.categories.overlays/categories.less
@@ -11,14 +11,14 @@
.category-header {
/* source:
http://lea.verou.me/2011/01/styling-children-based-on-their-number-with-css3/ */
/* width for two links */
- li:first-child:nth-last-child(2),
- li:first-child:nth-last-child(2) ~ li {
+ li:first-child:nth-last-child( 2 ),
+ li:first-child:nth-last-child( 2 ) ~ li {
width: 50%;
}
/* width for four links */
- li:first-child:nth-last-child(4),
- li:first-child:nth-last-child(4) ~ li {
+ li:first-child:nth-last-child( 4 ),
+ li:first-child:nth-last-child( 4 ) ~ li {
width: 25%;
}
diff --git a/resources/mobile.contentOverlays/tutorials.less
b/resources/mobile.contentOverlays/tutorials.less
index 202a469..dd25ad3 100644
--- a/resources/mobile.contentOverlays/tutorials.less
+++ b/resources/mobile.contentOverlays/tutorials.less
@@ -1,7 +1,7 @@
@import 'minerva.variables';
@import 'minerva.mixins';
-@media all and (min-width: @deviceWidthTablet) {
+@media all and ( min-width: @deviceWidthTablet ) {
// Take into account padding in width of pointer overlay so that it
// can point to anything in the containing content area and avoid
// padding issues such as https://phabricator.wikimedia.org/F287611
@@ -27,7 +27,7 @@
line-height: 1.4;
font-size: .9em;
text-align: center;
- box-shadow: 0 1px 5px 0 rgba(117, 117, 117, .8);
+ box-shadow: 0 1px 5px 0 rgba( 117, 117, 117, .8 );
margin-top: 10px;
p {
diff --git a/resources/mobile.drawers/drawer.less
b/resources/mobile.drawers/drawer.less
index b7f7bf0..5ba8248 100644
--- a/resources/mobile.drawers/drawer.less
+++ b/resources/mobile.drawers/drawer.less
@@ -39,7 +39,7 @@
}
p,
- a:not(:last-child),
+ a:not( :last-child ),
.mw-ui-button {
margin-bottom: 1em;
}
diff --git a/resources/mobile.editor.common/editor.less
b/resources/mobile.editor.common/editor.less
index 473c5df..643f82f 100644
--- a/resources/mobile.editor.common/editor.less
+++ b/resources/mobile.editor.common/editor.less
@@ -2,14 +2,14 @@
@import 'minerva.mixins';
.editor-overlay {
- .box-sizing(border-box);
+ .box-sizing( border-box );
.preview {
display: none;
}
.wikitext-editor {
- .box-sizing(border-box);
+ .box-sizing( border-box );
padding: 10px @contentMargin;
}
diff --git a/resources/mobile.editor.ve/VisualEditorOverlay.less
b/resources/mobile.editor.ve/VisualEditorOverlay.less
index ce21ad9..a798998 100644
--- a/resources/mobile.editor.ve/VisualEditorOverlay.less
+++ b/resources/mobile.editor.ve/VisualEditorOverlay.less
@@ -65,7 +65,7 @@
// prevent disappearing after scrolling when
-webkit-overflow-scrolling: touch
// is used (http://stackoverflow.com/a/10170170)
.overlay-content * {
- -webkit-transform: translate(0,0);
+ -webkit-transform: translate( 0, 0 );
}
.overlay-content .surface {
@@ -76,10 +76,10 @@
@baseIconSize: 24px;
@targetIconSize: 32px;
.overlay-header-container {
- box-shadow: 0 1px 1px rgba(0, 0, 0, 0.1);
+ box-shadow: 0 1px 1px rgba( 0, 0, 0, 0.1 );
.ve-init-mw-mobileArticleTarget-toolbar {
- @media all and (min-width: @wgMFDeviceWidthDesktop) {
+ @media all and ( min-width: @wgMFDeviceWidthDesktop ) {
border: 1px solid @colorGrayLighter;
border-width: 0 1px;
}
diff --git a/resources/mobile.gallery/gallery.less
b/resources/mobile.gallery/gallery.less
index aa0b79c..78083d0 100644
--- a/resources/mobile.gallery/gallery.less
+++ b/resources/mobile.gallery/gallery.less
@@ -16,7 +16,7 @@
}
}
-@media all and (min-width: @deviceWidthTablet) {
+@media all and ( min-width: @deviceWidthTablet ) {
.image-list {
margin: auto;
}
diff --git a/resources/mobile.issues/issues.less
b/resources/mobile.issues/issues.less
index b5143be..46263e0 100644
--- a/resources/mobile.issues/issues.less
+++ b/resources/mobile.issues/issues.less
@@ -19,7 +19,7 @@
li {
border-bottom: solid 1px @grayLight;
.issue-notice {
- padding: (@smallIconSize * 2.5) @contentMargin
@smallIconSize @contentMargin;
+ padding: ( @smallIconSize * 2.5 )
@contentMargin @smallIconSize @contentMargin;
// on mobile move the icon above the content
&:before {
@@ -33,12 +33,12 @@
}
}
-@media all and (min-width: @deviceWidthTablet) {
+@media all and ( min-width: @deviceWidthTablet ) {
.overlay {
.cleanup {
li {
.issue-notice {
- padding: 2em 1em 2em (@largeIconSize +
10px);
+ padding: 2em 1em 2em ( @largeIconSize +
10px );
margin: 0 1em 0 @headerHeight;
// FIXME: Please remove this. It should
not care about how icons are rendered.
diff --git a/resources/mobile.languages.structured/LanguageOverlay.less
b/resources/mobile.languages.structured/LanguageOverlay.less
index 27d2e44..6d48b2d 100644
--- a/resources/mobile.languages.structured/LanguageOverlay.less
+++ b/resources/mobile.languages.structured/LanguageOverlay.less
@@ -90,7 +90,7 @@
}
}
-@media all and (min-width: @deviceWidthTablet) {
+@media all and ( min-width: @deviceWidthTablet ) {
.language-overlay {
.site-link-list {
padding-left: 0;
@@ -99,7 +99,7 @@
}
}
-@media all and (min-width: @wgMFDeviceWidthDesktop) {
+@media all and ( min-width: @wgMFDeviceWidthDesktop ) {
.language-overlay {
.overlay-content {
margin: 0;
diff --git a/resources/mobile.mainMenu/mainmenu.less
b/resources/mobile.mainMenu/mainmenu.less
index a80ce55..8a277f8 100644
--- a/resources/mobile.mainMenu/mainmenu.less
+++ b/resources/mobile.mainMenu/mainmenu.less
@@ -49,7 +49,7 @@
height: 100%;
width: auto;
- box-shadow: -5px 0 0 0 rgba(0, 0, 0, 0.3);
+ box-shadow: -5px 0 0 0 rgba( 0, 0, 0, 0.3 );
}
nav {
@@ -156,7 +156,7 @@
left: @menuWidth;
// set border here (nav doesn't expand height)
border-left: solid 1px #000;
- box-shadow: -1px 0 3px 0 rgba(0, 0, 0, .3);
+ box-shadow: -1px 0 3px 0 rgba( 0, 0, 0, .3 );
}
.navigation-drawer,
@@ -183,7 +183,7 @@
}
}
-@media all and (min-width: @deviceWidthTablet) {
+@media all and ( min-width: @deviceWidthTablet ) {
@rightDrawerLeftOffset: 100% - @rightDrawerWidth;
.secondary-navigation-enabled {
#mw-mf-page-center {
@@ -215,14 +215,14 @@
background-color: #fff;
// *2 to avoid weird glitch of left nav flickering after closing
- @transition: @duration @easing, height 0s (@duration*2);
- .transition-transform(@transition);
+ @transition: @duration @easing, height 0s ( @duration * 2 );
+ .transition-transform( @transition );
}
nav {
width: @menuWidth;
- .transition(visibility 0s @duration);
+ .transition( visibility 0s @duration );
}
// FIXME: Make animations a conditional class on the drawer itself
@@ -230,11 +230,11 @@
display: block;
// +2% to accommodate for the border/box-shadow
- .transform(translate(102%, 0));
- .transition-transform(@duration @easing, visibility 0s
@duration;);
+ .transform( translate( 102%, 0 ) );
+ .transition-transform( @duration @easing, visibility 0s
@duration; );
&.visible {
- .transform(translate(0, 0));
+ .transform( translate( 0, 0 ) );
}
}
}
@@ -243,7 +243,7 @@
// FIXME: Menu shouldn't need to know about drawers but a cta drawer
might be open
.drawer .position-fixed,
#mw-mf-page-center {
- .transition-transform(@duration @easing);
+ .transition-transform( @duration @easing );
}
}
@@ -253,14 +253,14 @@
#mw-mf-page-center {
// override non-animated version
left: 0 !important;
- .transform(translate(@menuWidth, 0));
+ .transform( translate( @menuWidth, 0 ) );
}
nav {
// make menu scrollable when open (on small screens)
position: static;
- .transition(none);
+ .transition( none );
}
}
@@ -268,7 +268,7 @@
#mw-mf-page-center {
// override non-animated version
left: 0 !important;
- .transform(translate(-@rightDrawerWidth, 0));
+ .transform( translate( -@rightDrawerWidth, 0 ) );
width: 100%;
}
}
@@ -277,10 +277,10 @@
// FIXME: Make animations a conditional class on the drawer itself
.animations .notifications-overlay.navigation-drawer {
// +2% to accommodate for the border/box-shadow
- .transform(translate(-102%, 0));
+ .transform( translate( -102%, 0 ) );
&.visible {
- .transform(translate(0, 0));
+ .transform( translate( 0, 0 ) );
}
}
@@ -288,13 +288,13 @@
// FIXME: Menu shouldn't need to know about drawers
.drawer .position-fixed,
#mw-mf-page-center {
- .transform(translate(-@menuWidth, 0));
+ .transform( translate( -@menuWidth, 0 ) );
}
}
&.secondary-navigation-enabled.animations {
#mw-mf-page-center {
- .transform(translate(@rightDrawerWidth, 0));
+ .transform( translate( @rightDrawerWidth, 0 ) );
}
}
}
diff --git a/resources/mobile.notifications.overlay/NotificationsOverlay.less
b/resources/mobile.notifications.overlay/NotificationsOverlay.less
index d1fe5f7..5b51f65 100644
--- a/resources/mobile.notifications.overlay/NotificationsOverlay.less
+++ b/resources/mobile.notifications.overlay/NotificationsOverlay.less
@@ -62,7 +62,7 @@
}
}
-@media all and (min-width: @deviceWidthTablet) {
+@media all and ( min-width: @deviceWidthTablet ) {
.notifications-overlay {
.mw-echo-notification {
padding: 1.75em @contentPaddingTablet;
diff --git a/resources/mobile.overlays/Overlay.less
b/resources/mobile.overlays/Overlay.less
index b485845..e43a135 100644
--- a/resources/mobile.overlays/Overlay.less
+++ b/resources/mobile.overlays/Overlay.less
@@ -5,7 +5,7 @@
@contentHeaderBorderColor: #e2e2e2;
.mw-ui-icon-back {
- .m-background-image('back-ltr.png');
+ .m-background-image( 'back-ltr.png' );
}
.content-overlay {
@@ -381,7 +381,7 @@
}
}
-@media all and (min-width: @deviceWidthTablet) {
+@media all and ( min-width: @deviceWidthTablet ) {
.overlay {
.panel {
padding: 12px @contentPaddingTablet;
@@ -389,7 +389,7 @@
}
}
-@media all and (min-width: @wgMFDeviceWidthDesktop) {
+@media all and ( min-width: @wgMFDeviceWidthDesktop ) {
.overlay-header {
// Make sure the close button and secondary button icon images
are aligned
// with the content.
diff --git a/resources/mobile.pagelist.styles/pagelist.less
b/resources/mobile.pagelist.styles/pagelist.less
index 3e72d83..9207d64 100644
--- a/resources/mobile.pagelist.styles/pagelist.less
+++ b/resources/mobile.pagelist.styles/pagelist.less
@@ -149,7 +149,7 @@
}
// FIXME: combine with a similar pattern in modules/NotificationsOverlay.less
-@media all and (min-width: @deviceWidthTablet) {
+@media all and ( min-width: @deviceWidthTablet ) {
// FIXME: this should be one generic class name
.page-summary-list,
.topic-title-list,
diff --git a/resources/mobile.pagesummary.styles/pagesummary.less
b/resources/mobile.pagesummary.styles/pagesummary.less
index c0cfd45..d012f3b 100644
--- a/resources/mobile.pagesummary.styles/pagesummary.less
+++ b/resources/mobile.pagesummary.styles/pagesummary.less
@@ -48,7 +48,7 @@
&.list-thumb-none {
background-color: @grayLightest;
- .background-image-svg-quick('noimage');
+ .background-image-svg-quick( 'noimage' );
}
&.list-thumb-x {
@@ -60,7 +60,7 @@
}
}
-@media all and (min-width: @deviceWidthTablet) {
+@media all and ( min-width: @deviceWidthTablet ) {
.list-header {
padding: .5em @contentPaddingTablet .4em @contentMargin;
}
diff --git a/resources/mobile.references/references.less
b/resources/mobile.references/references.less
index bd5173b..939924c 100644
--- a/resources/mobile.references/references.less
+++ b/resources/mobile.references/references.less
@@ -25,7 +25,7 @@
}
.error {
- .background-image('images/error.png');
+ .background-image( 'images/error.png' );
padding-left: 20px;
background-repeat: no-repeat;
}
diff --git a/resources/mobile.search/SearchOverlay.less
b/resources/mobile.search/SearchOverlay.less
index da1f5f4..ed3d47f 100644
--- a/resources/mobile.search/SearchOverlay.less
+++ b/resources/mobile.search/SearchOverlay.less
@@ -4,11 +4,11 @@
@thumbGap: 15px;
@thumbWidth: 70px;
.mw-ui-icon-clear {
- .m-background-image('clear.png');
+ .m-background-image( 'clear.png' );
}
.mw-ui-icon-search-content {
- .m-background-image('search-content.png');
+ .m-background-image( 'search-content.png' );
}
.search-overlay {
@@ -53,7 +53,7 @@
}
.results {
- box-shadow: 0 3px 3px 0 rgba(117, 117, 117, .3);
+ box-shadow: 0 3px 3px 0 rgba( 117, 117, 117, .3 );
// Since search results only contain one line, shrink the space
taken up by the thumbnails
li {
@@ -95,7 +95,7 @@
}
.search-feedback {
- box-shadow: 0 3px 3px 0 rgba(117, 117, 117, .3);
+ box-shadow: 0 3px 3px 0 rgba( 117, 117, 117, .3 );
border-top: 1px solid @colorGray12;
font-size: .8em;
padding: .5em 1em;
@@ -126,10 +126,10 @@
.animations {
.search-overlay {
&.visible {
- .animation(fadeIn .5s);
+ .animation( fadeIn .5s );
}
&.fade-out {
- .animation(fadeOut .5s);
+ .animation( fadeOut .5s );
}
}
}
diff --git a/resources/mobile.special.mobilediff.styles/icons.less
b/resources/mobile.special.mobilediff.styles/icons.less
index 9900d48..0e2433b 100644
--- a/resources/mobile.special.mobilediff.styles/icons.less
+++ b/resources/mobile.special.mobilediff.styles/icons.less
@@ -5,13 +5,13 @@
// Diffs set
.mw-ui-icon-bytesadded {
- .m-background-image('positive.png');
+ .m-background-image( 'positive.png' );
}
.mw-ui-icon-bytesremoved {
- .m-background-image('negative.png');
+ .m-background-image( 'negative.png' );
}
.mw-ui-icon-bytesneutral {
- .m-background-image('neutral.png');
+ .m-background-image( 'neutral.png' );
}
diff --git a/resources/mobile.special.mobilediff.styles/mobilediff.less
b/resources/mobile.special.mobilediff.styles/mobilediff.less
index 02554f9..ef3a147 100644
--- a/resources/mobile.special.mobilediff.styles/mobilediff.less
+++ b/resources/mobile.special.mobilediff.styles/mobilediff.less
@@ -13,7 +13,7 @@
// FIXME: Overly specific selector
#mw-mf-diffarea {
- padding: 1em 1em (2 * @userInfoHeight + 1em);
+ padding: 1em 1em ( 2 * @userInfoHeight + 1em );
}
#mw-mf-diffview {
@@ -116,7 +116,7 @@
margin-top: 8px;
}
-@media all and (min-width: @wgMFDeviceWidthDesktop) {
+@media all and ( min-width: @wgMFDeviceWidthDesktop ) {
// FIXME: Overly specific selector
.beta #mw-mf-diffarea {
padding-left: 0;
diff --git a/resources/mobile.special.uploads.styles/uploads.less
b/resources/mobile.special.uploads.styles/uploads.less
index 1d9decb..8bf0aa0 100644
--- a/resources/mobile.special.uploads.styles/uploads.less
+++ b/resources/mobile.special.uploads.styles/uploads.less
@@ -11,7 +11,7 @@
}
}
-@media all and (min-width: @deviceWidthTablet) {
+@media all and ( min-width: @deviceWidthTablet ) {
.ctaUploadPhoto {
border-bottom: none;
background: none;
diff --git a/resources/mobile.toast/toast.less
b/resources/mobile.toast/toast.less
index 3e6378a..15cb1b5 100644
--- a/resources/mobile.toast/toast.less
+++ b/resources/mobile.toast/toast.less
@@ -32,7 +32,7 @@
left: 0;
right: 0;
background-color: @searchBoxColorTo;
- box-shadow: 0 -1px 8px 0 rgba(0, 0, 0, 0.35);
+ box-shadow: 0 -1px 8px 0 rgba( 0, 0, 0, 0.35 );
word-wrap: break-word;
// needs to be higher than for overlays to show on top of overlays
z-index: @z-indexOverOverlay;
@@ -53,7 +53,7 @@
/* we can't determine the actual size of the drawer in CSS, so
this is
* an estimate; it doesn't have to be exact because it's used
only for
* the sliding animation, not for hiding the drawer */
- .transform( translate(0, 100px) );
+ .transform( translate( 0, 100px ) );
// counter translate with bottom to avoid empty blank space at
the bottom
// especially on browsers that don't support position: fixed
bottom: 100px;
@@ -77,7 +77,7 @@
.transition-transform( @transition );
visibility: visible;
opacity: 1;
- .transform( translate(0, 0) );
+ .transform( translate( 0, 0 ) );
}
}
}
@@ -104,7 +104,7 @@
//
// Styleguide 3.2.
&.mw-notification-type-error {
- .background-image('images/error.png');
+ .background-image( 'images/error.png' );
background-position: 16px 50%;
background-repeat: no-repeat;
padding-left: 5%;
diff --git a/resources/mobile.toc/toc.less b/resources/mobile.toc/toc.less
index df942d2..bc82dc5 100644
--- a/resources/mobile.toc/toc.less
+++ b/resources/mobile.toc/toc.less
@@ -34,7 +34,7 @@
border-bottom: none;
margin-left: @paddingHorizontal + @iconSize + @iconHeadingGap;
margin-right: @paddingHorizontal;
- font-size: (7 * @fontSize) / 8;
+ font-size: ( 7 * @fontSize ) / 8;
width: auto;
> ul {
padding-bottom: @fontSize + @headingMargin;
diff --git a/resources/mobile.watchstar/watchstar.less
b/resources/mobile.watchstar/watchstar.less
index 1dd092c..d0f7998 100644
--- a/resources/mobile.watchstar/watchstar.less
+++ b/resources/mobile.watchstar/watchstar.less
@@ -5,7 +5,7 @@
.watch-this-article {
.transition-transform( .5s );
&.watched {
- .transform( rotate(72deg) );
+ .transform( rotate( 72deg ) );
}
}
}
diff --git a/resources/skins.minerva.base.styles/common.less
b/resources/skins.minerva.base.styles/common.less
index 41a388a..d9eb761 100644
--- a/resources/skins.minerva.base.styles/common.less
+++ b/resources/skins.minerva.base.styles/common.less
@@ -33,7 +33,7 @@
.view-border-box *,
.view-border-box {
- .box-sizing(border-box);
+ .box-sizing( border-box );
}
.mw-mf-image-replacement {
diff --git a/resources/skins.minerva.base.styles/icons.less
b/resources/skins.minerva.base.styles/icons.less
index efff273..ec2e3d5 100644
--- a/resources/skins.minerva.base.styles/icons.less
+++ b/resources/skins.minerva.base.styles/icons.less
@@ -11,7 +11,7 @@
.open-block {
.mw-ui-icon-arrow:before {
- -webkit-transform: scaleY(-1);
- transform: scaleY(-1);
+ -webkit-transform: scaleY( -1 );
+ transform: scaleY( -1 );
}
}
diff --git a/resources/skins.minerva.base.styles/images.less
b/resources/skins.minerva.base.styles/images.less
index 9978bd4..a8f9205 100644
--- a/resources/skins.minerva.base.styles/images.less
+++ b/resources/skins.minerva.base.styles/images.less
@@ -33,12 +33,12 @@
// When the image has loaded transition background color and image
opacity
// for a fade-in effect
&.loaded {
- .animation(fadeOutContainer @animationDuration ease-in);
+ .animation( fadeOutContainer @animationDuration ease-in );
background-color: transparent;
border: none;
img {
- .animation(fadeInImage @animationDuration ease-in);
+ .animation( fadeInImage @animationDuration ease-in );
opacity: 1;
}
}
diff --git a/resources/skins.minerva.base.styles/pageactions.less
b/resources/skins.minerva.base.styles/pageactions.less
index 1c5fd14..0c8aea4 100644
--- a/resources/skins.minerva.base.styles/pageactions.less
+++ b/resources/skins.minerva.base.styles/pageactions.less
@@ -84,7 +84,7 @@
}
// On small devices that don't support Javascript, hide the page actions bar
-@media all and (max-width: @wgMFDeviceWidthMobileSmall) {
+@media all and ( max-width: @wgMFDeviceWidthMobileSmall ) {
.client-nojs {
#page-actions {
display: none;
diff --git a/resources/skins.minerva.base.styles/ui.less
b/resources/skins.minerva.base.styles/ui.less
index dd1d3f5..9e3fd72 100644
--- a/resources/skins.minerva.base.styles/ui.less
+++ b/resources/skins.minerva.base.styles/ui.less
@@ -24,7 +24,7 @@
a:visited {
color: @colorGray6;
// If browser supports
- &:nth-child(2) {
+ &:nth-child( 2 ) {
font-weight: bold;
}
}
@@ -101,7 +101,7 @@
// Make search input more visible for users on small screens.
// Opera Mini doesn't support placeholders.
-@media all and (max-width: @wgMFDeviceWidthMobileSmall) {
+@media all and ( max-width: @wgMFDeviceWidthMobileSmall ) {
.header {
.search {
border: 1px solid @grayLight;
@@ -151,7 +151,7 @@
// FIXME: remove when micro.tap in stable and rule from common-js.less too
.search-box {
- -webkit-tap-highlight-color: rgba(255, 255, 255, 0);
+ -webkit-tap-highlight-color: rgba( 255, 255, 255, 0 );
}
.content {
diff --git a/resources/skins.minerva.beta.styles/pageactions.less
b/resources/skins.minerva.beta.styles/pageactions.less
index 4dfd857..2323bd3 100644
--- a/resources/skins.minerva.beta.styles/pageactions.less
+++ b/resources/skins.minerva.beta.styles/pageactions.less
@@ -32,7 +32,7 @@
}
}
-@media all and (min-width: @deviceWidthTablet) {
+@media all and ( min-width: @deviceWidthTablet ) {
.heading-holder {
position: relative;
}
diff --git a/resources/skins.minerva.content.styles/hacks.less
b/resources/skins.minerva.content.styles/hacks.less
index 0e5094a..3a5ed2b 100644
--- a/resources/skins.minerva.content.styles/hacks.less
+++ b/resources/skins.minerva.content.styles/hacks.less
@@ -110,7 +110,7 @@
}
// Hacks to render galleries and multicol tables better on mobile
-@media all and (max-width: @deviceWidthTablet) {
+@media all and ( max-width: @deviceWidthTablet ) {
// Center images that might be less than the screen width.
// Image will appear centered and caption will take up full screen.
diff --git a/resources/skins.minerva.content.styles/main.less
b/resources/skins.minerva.content.styles/main.less
index 8554178..d800f4e 100644
--- a/resources/skins.minerva.content.styles/main.less
+++ b/resources/skins.minerva.content.styles/main.less
@@ -34,7 +34,7 @@
word-wrap: break-word;
}
-@media all and (max-width: @wgMFDeviceWidthMobileSmall) {
+@media all and ( max-width: @wgMFDeviceWidthMobileSmall ) {
body {
font-size: .8em;
}
diff --git a/resources/skins.minerva.special.userlogin.styles/userlogin.less
b/resources/skins.minerva.special.userlogin.styles/userlogin.less
index 243d87b..bfb22b3 100644
--- a/resources/skins.minerva.special.userlogin.styles/userlogin.less
+++ b/resources/skins.minerva.special.userlogin.styles/userlogin.less
@@ -32,7 +32,7 @@
background: none;
&:before {
content: '';
- .background-image-svg('icons/refresh.svg',
'icons/refresh.png');
+ .background-image-svg( 'icons/refresh.svg',
'icons/refresh.png' );
background-position: center left;
background-repeat: no-repeat;
background-size: 16px;
@@ -93,7 +93,7 @@
background: #fff;
text-align: center;
- input:not([type=submit]), img, #wpCaptchaWord {
+ input:not( [type=submit] ), img, #wpCaptchaWord {
border: none;
border-top: solid 1px @colorGray12;
@@ -102,7 +102,7 @@
}
}
- input:not([type=submit]) {
+ input:not( [type=submit] ) {
-webkit-appearance: none;
border-radius: 0;
padding: .8em .5em;
@@ -133,7 +133,7 @@
}
// FIXME: Some of these rules should actually be mobile first, only hiding
inputs needs to be wrapped in a media query
-@media all and (max-width: @deviceWidthTablet) {
+@media all and ( max-width: @deviceWidthTablet ) {
@margin: 12px;
#userloginForm {
diff --git
a/resources/skins.minerva.special.watchlist.styles/specialWatchlist.less
b/resources/skins.minerva.special.watchlist.styles/specialWatchlist.less
index 2cbe821..382e781 100644
--- a/resources/skins.minerva.special.watchlist.styles/specialWatchlist.less
+++ b/resources/skins.minerva.special.watchlist.styles/specialWatchlist.less
@@ -7,7 +7,7 @@
}
}
-@media all and (min-width: @deviceWidthTablet) {
+@media all and ( min-width: @deviceWidthTablet ) {
#bodyContent {
.content-header {
border-bottom: none;
diff --git a/resources/skins.minerva.tablet.styles/common.less
b/resources/skins.minerva.tablet.styles/common.less
index 47cf533..ec2a8ef 100644
--- a/resources/skins.minerva.tablet.styles/common.less
+++ b/resources/skins.minerva.tablet.styles/common.less
@@ -6,7 +6,7 @@
@import 'minerva.mixins';
@paddingVertical: 1.4em;
-@media all and (min-width: @deviceWidthTablet) {
+@media all and ( min-width: @deviceWidthTablet ) {
.toc-mobile {
// Reset the rule for mobile mode (but not for .client-nojs)
display: block;
@@ -143,7 +143,7 @@
}
}
-@media all and (min-width: @wgMFDeviceWidthDesktop) {
+@media all and ( min-width: @wgMFDeviceWidthDesktop ) {
// FIXME: Zero should use banner-container class or better - append to
banner-container
#mw-mf-page-center .mw-mf-banner,
.banner-container,
diff --git a/resources/skins.minerva.tablet.styles/hacks.less
b/resources/skins.minerva.tablet.styles/hacks.less
index 5edb788..1682fcd 100644
--- a/resources/skins.minerva.tablet.styles/hacks.less
+++ b/resources/skins.minerva.tablet.styles/hacks.less
@@ -12,7 +12,7 @@
@import 'minerva.mixins';
/* Tablet specific styling */
-@media all and (min-width: @deviceWidthTablet) {
+@media all and ( min-width: @deviceWidthTablet ) {
// Float infoboxes to the right of the page
table.infobox {
margin: .5em 0 1em 35px !important;
diff --git a/resources/skins.minerva.talk/talk.less
b/resources/skins.minerva.talk/talk.less
index cf0a088..684430c 100644
--- a/resources/skins.minerva.talk/talk.less
+++ b/resources/skins.minerva.talk/talk.less
@@ -40,7 +40,7 @@
}
}
-@media all and (min-width: @deviceWidthTablet) {
+@media all and ( min-width: @deviceWidthTablet ) {
.content.talk-section {
margin: 0 auto 0 0;
}
--
To view, visit https://gerrit.wikimedia.org/r/290223
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idfc53aee2da50f31ddd9f26daaaa968c583069c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
