Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/290222
Change subject: Stylelint: Add newline and indent rules
......................................................................
Stylelint: Add newline and indent rules
Change-Id: I04d3304493ea2e99143cf018ed017bab313d325f
---
M .stylelintrc
M resources/mobile.ajax/spinner.less
M resources/mobile.betaoptin/panel.less
M resources/mobile.categories.overlays/categories.less
M resources/mobile.contentOverlays/tutorials.less
M resources/mobile.drawers/drawer.less
M resources/mobile.mainMenu/mainmenu.less
M resources/mobile.special.mobilediff.styles/icons.less
M resources/mobile.talk.overlays/TalkOverlay.less
M resources/mobile.toast/toast.less
M resources/skins.minerva.base.styles/common.less
M resources/skins.minerva.base.styles/icons.less
M resources/skins.minerva.beta.styles/ui.less
M resources/skins.minerva.content.styles/blockquotes.less
M resources/skins.minerva.content.styles/galleries.less
M resources/skins.minerva.content.styles/links.less
M resources/skins.minerva.content.styles/thumbnails.less
M resources/skins.minerva.special.styles/common.less
M resources/skins.minerva.userpage.styles/userpage.less
19 files changed, 16 insertions(+), 19 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/22/290222/1
diff --git a/.stylelintrc b/.stylelintrc
index 8866695..47048b4 100644
--- a/.stylelintrc
+++ b/.stylelintrc
@@ -1,5 +1,10 @@
{
"rules": {
+ "indentation": [ "tab" ],
+ "max-empty-lines": 1,
+ "no-eol-whitespace": true,
+ "no-missing-eof-newline": true,
+
"color-hex-case": [ "lower" ],
"color-hex-length": [ "short" ],
"color-named": [ "never" ],
diff --git a/resources/mobile.ajax/spinner.less
b/resources/mobile.ajax/spinner.less
index 49bedf2..5a76a5e 100644
--- a/resources/mobile.ajax/spinner.less
+++ b/resources/mobile.ajax/spinner.less
@@ -2,7 +2,6 @@
@import 'minerva.mixins';
@import 'mediawiki.mixins.less';
-
// FIXME: Standardise on a loading class (update ConfirmEdit extension)
.fancycaptcha-reload-loading,
.mw-ui-icon-spinner {
diff --git a/resources/mobile.betaoptin/panel.less
b/resources/mobile.betaoptin/panel.less
index 040c96d..01e9084 100644
--- a/resources/mobile.betaoptin/panel.less
+++ b/resources/mobile.betaoptin/panel.less
@@ -5,4 +5,4 @@
&.visible {
display: block;
}
-}
\ No newline at end of file
+}
diff --git a/resources/mobile.categories.overlays/categories.less
b/resources/mobile.categories.overlays/categories.less
index 68be2e6..e928f7a 100644
--- a/resources/mobile.categories.overlays/categories.less
+++ b/resources/mobile.categories.overlays/categories.less
@@ -47,4 +47,4 @@
border-bottom: 3px solid transparent;
}
}
-}
\ No newline at end of file
+}
diff --git a/resources/mobile.contentOverlays/tutorials.less
b/resources/mobile.contentOverlays/tutorials.less
index a31bf4d..202a469 100644
--- a/resources/mobile.contentOverlays/tutorials.less
+++ b/resources/mobile.contentOverlays/tutorials.less
@@ -1,7 +1,6 @@
@import 'minerva.variables';
@import 'minerva.mixins';
-
@media all and (min-width: @deviceWidthTablet) {
// Take into account padding in width of pointer overlay so that it
// can point to anything in the containing content area and avoid
diff --git a/resources/mobile.drawers/drawer.less
b/resources/mobile.drawers/drawer.less
index 734773b..b7f7bf0 100644
--- a/resources/mobile.drawers/drawer.less
+++ b/resources/mobile.drawers/drawer.less
@@ -1,7 +1,6 @@
@import 'minerva.variables';
@import 'minerva.mixins';
-
// Drawers
//
// Drawers appear at the bottom of the page and contain CTAs
diff --git a/resources/mobile.mainMenu/mainmenu.less
b/resources/mobile.mainMenu/mainmenu.less
index b0d051a..a80ce55 100644
--- a/resources/mobile.mainMenu/mainmenu.less
+++ b/resources/mobile.mainMenu/mainmenu.less
@@ -239,7 +239,6 @@
}
}
-
.navigation-enabled.animations {
// FIXME: Menu shouldn't need to know about drawers but a cta drawer
might be open
.drawer .position-fixed,
diff --git a/resources/mobile.special.mobilediff.styles/icons.less
b/resources/mobile.special.mobilediff.styles/icons.less
index a621d7a..9900d48 100644
--- a/resources/mobile.special.mobilediff.styles/icons.less
+++ b/resources/mobile.special.mobilediff.styles/icons.less
@@ -3,7 +3,6 @@
@import 'minerva.mixins';
@import 'mediawiki.mixins';
-
// Diffs set
.mw-ui-icon-bytesadded {
.m-background-image('positive.png');
@@ -15,4 +14,4 @@
.mw-ui-icon-bytesneutral {
.m-background-image('neutral.png');
-}
\ No newline at end of file
+}
diff --git a/resources/mobile.talk.overlays/TalkOverlay.less
b/resources/mobile.talk.overlays/TalkOverlay.less
index 1490496..7a8f726 100644
--- a/resources/mobile.talk.overlays/TalkOverlay.less
+++ b/resources/mobile.talk.overlays/TalkOverlay.less
@@ -14,4 +14,4 @@
border: 0;
}
}
-}
\ No newline at end of file
+}
diff --git a/resources/mobile.toast/toast.less
b/resources/mobile.toast/toast.less
index 1852856..3e6378a 100644
--- a/resources/mobile.toast/toast.less
+++ b/resources/mobile.toast/toast.less
@@ -44,7 +44,6 @@
}
}
-
.animations {
.mw-notification,
.drawer {
diff --git a/resources/skins.minerva.base.styles/common.less
b/resources/skins.minerva.base.styles/common.less
index 462122d..41a388a 100644
--- a/resources/skins.minerva.base.styles/common.less
+++ b/resources/skins.minerva.base.styles/common.less
@@ -51,7 +51,6 @@
resize: none;
}
-
// We hide the table of contents unless the user is viewing in tablet
resolution or higher
.toc-mobile,
// We also need a more specific rule for tablet non-JS users who will load
skins.minerva.tablet.styles
diff --git a/resources/skins.minerva.base.styles/icons.less
b/resources/skins.minerva.base.styles/icons.less
index 44b087a..efff273 100644
--- a/resources/skins.minerva.base.styles/icons.less
+++ b/resources/skins.minerva.base.styles/icons.less
@@ -14,4 +14,4 @@
-webkit-transform: scaleY(-1);
transform: scaleY(-1);
}
-}
\ No newline at end of file
+}
diff --git a/resources/skins.minerva.beta.styles/ui.less
b/resources/skins.minerva.beta.styles/ui.less
index e44d503..9d6fb2b 100644
--- a/resources/skins.minerva.beta.styles/ui.less
+++ b/resources/skins.minerva.beta.styles/ui.less
@@ -47,4 +47,4 @@
width: 100%;
}
}
-}
\ No newline at end of file
+}
diff --git a/resources/skins.minerva.content.styles/blockquotes.less
b/resources/skins.minerva.content.styles/blockquotes.less
index 5fa204d..50bb4f1 100644
--- a/resources/skins.minerva.content.styles/blockquotes.less
+++ b/resources/skins.minerva.content.styles/blockquotes.less
@@ -34,4 +34,4 @@
right: 0;
bottom: 0;
}
-}
\ No newline at end of file
+}
diff --git a/resources/skins.minerva.content.styles/galleries.less
b/resources/skins.minerva.content.styles/galleries.less
index 3d8756a..00c6c75 100644
--- a/resources/skins.minerva.content.styles/galleries.less
+++ b/resources/skins.minerva.content.styles/galleries.less
@@ -37,4 +37,4 @@
font-size: .8em;
}
}
-}
\ No newline at end of file
+}
diff --git a/resources/skins.minerva.content.styles/links.less
b/resources/skins.minerva.content.styles/links.less
index 06793bc..e114601 100644
--- a/resources/skins.minerva.content.styles/links.less
+++ b/resources/skins.minerva.content.styles/links.less
@@ -46,4 +46,4 @@
.plainlinks a {
background: none !important;
padding: 0 !important;
-}
\ No newline at end of file
+}
diff --git a/resources/skins.minerva.content.styles/thumbnails.less
b/resources/skins.minerva.content.styles/thumbnails.less
index 5b603e8..c581d3a 100644
--- a/resources/skins.minerva.content.styles/thumbnails.less
+++ b/resources/skins.minerva.content.styles/thumbnails.less
@@ -52,4 +52,4 @@
.thumbborder {
border: 1px solid @colorGray12;
}
-}
\ No newline at end of file
+}
diff --git a/resources/skins.minerva.special.styles/common.less
b/resources/skins.minerva.special.styles/common.less
index de4e5a6..6b26f61 100644
--- a/resources/skins.minerva.special.styles/common.less
+++ b/resources/skins.minerva.special.styles/common.less
@@ -1,7 +1,6 @@
@import 'minerva.variables';
@import 'minerva.mixins';
-
// FIXME: Apply these styles to all special pages
.mw-mf-special {
.content-header {
diff --git a/resources/skins.minerva.userpage.styles/userpage.less
b/resources/skins.minerva.userpage.styles/userpage.less
index 2790c1f..118ebc4 100755
--- a/resources/skins.minerva.userpage.styles/userpage.less
+++ b/resources/skins.minerva.userpage.styles/userpage.less
@@ -59,4 +59,4 @@
color: @colorGray9;
margin-bottom: 20px;
}
-}
\ No newline at end of file
+}
--
To view, visit https://gerrit.wikimedia.org/r/290222
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I04d3304493ea2e99143cf018ed017bab313d325f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
