Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/290229
Change subject: Stylelint: Add no duplicate selectors rule
......................................................................
Stylelint: Add no duplicate selectors rule
Change-Id: Ieb2ac43aa67cbf357166f7476c34b7ff4baa7b53
---
M .stylelintrc
M resources/skins.minerva.special.styles/common.less
M resources/skins.minerva.tablet.styles/common.less
3 files changed, 14 insertions(+), 19 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/29/290229/1
diff --git a/.stylelintrc b/.stylelintrc
index d6f0e25..33f1f00 100644
--- a/.stylelintrc
+++ b/.stylelintrc
@@ -5,6 +5,8 @@
"no-eol-whitespace": true,
"no-missing-eof-newline": true,
+ "no-duplicate-selectors": true,
+
"color-hex-case": [ "lower" ],
"color-hex-length": [ "short" ],
"color-named": [ "never" ],
diff --git a/resources/skins.minerva.special.styles/common.less
b/resources/skins.minerva.special.styles/common.less
index 6b26f61..e01c984 100644
--- a/resources/skins.minerva.special.styles/common.less
+++ b/resources/skins.minerva.special.styles/common.less
@@ -2,21 +2,6 @@
@import 'minerva.mixins';
// FIXME: Apply these styles to all special pages
-.mw-mf-special {
- .content-header {
- padding: 0 0 20px;
- border-bottom: 1px solid @headerBorderBottom;
-
- h2 {
- padding: 0;
- font-size: 1.1em;
- font-weight: bold;
- border-bottom: none;
- text-align: center;
- }
- }
-}
-
.mw-mf-special #content {
@verticalPadding: .5em;
#section_0 {
@@ -31,10 +16,21 @@
padding: 0;
border-bottom: none;
}
-
}
.mw-mf-special {
+ .content-header {
+ padding: 0 0 20px;
+ border-bottom: 1px solid @headerBorderBottom;
+
+ h2 {
+ padding: 0;
+ font-size: 1.1em;
+ font-weight: bold;
+ border-bottom: none;
+ text-align: center;
+ }
+ }
.content {
// don't apply these styles to headings in message boxes
diff --git a/resources/skins.minerva.tablet.styles/common.less
b/resources/skins.minerva.tablet.styles/common.less
index ec2a8ef..f4dba46 100644
--- a/resources/skins.minerva.tablet.styles/common.less
+++ b/resources/skins.minerva.tablet.styles/common.less
@@ -35,9 +35,6 @@
.heading-holder {
padding: 20px 0;
- }
-
- .heading-holder {
position: relative;
#section_0 {
--
To view, visit https://gerrit.wikimedia.org/r/290229
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb2ac43aa67cbf357166f7476c34b7ff4baa7b53
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
