Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/290235
Change subject: SelectWidget: Implement #getFirstSelectableItem in terms of
#getRelativeSelectableItem
......................................................................
SelectWidget: Implement #getFirstSelectableItem in terms of
#getRelativeSelectableItem
Also, document #getRelativeSelectableItem's 'filter' parameter as optional.
Change-Id: I07ec1cced6bf2b58abe7c55f6ab71da3390f0a64
---
M src/widgets/SelectWidget.js
1 file changed, 2 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/35/290235/1
diff --git a/src/widgets/SelectWidget.js b/src/widgets/SelectWidget.js
index 83565bd..71efc0a 100644
--- a/src/widgets/SelectWidget.js
+++ b/src/widgets/SelectWidget.js
@@ -738,7 +738,7 @@
*
* @param {OO.ui.OptionWidget|null} item Item to describe the start position,
or `null` to start at the beginning of the array.
* @param {number} direction Direction to move in: -1 to move backward, 1 to
move forward
- * @param {Function} filter Only consider items for which this function returns
+ * @param {Function} [filter] Only consider items for which this function
returns
* true. Function takes an OO.ui.OptionWidget and returns a boolean.
* @return {OO.ui.OptionWidget|null} Item at position, `null` if there are no
items in the select
*/
@@ -777,16 +777,7 @@
* @return {OO.ui.OptionWidget|null} Item, `null` if there aren't any
selectable items
*/
OO.ui.SelectWidget.prototype.getFirstSelectableItem = function () {
- var i, len, item;
-
- for ( i = 0, len = this.items.length; i < len; i++ ) {
- item = this.items[ i ];
- if ( item instanceof OO.ui.OptionWidget && item.isSelectable()
) {
- return item;
- }
- }
-
- return null;
+ return this.getRelativeSelectableItem( null, 1 );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/290235
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07ec1cced6bf2b58abe7c55f6ab71da3390f0a64
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
