Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/290358
Change subject: build: Align to stylelint-config-wikimedia for !important
......................................................................
build: Align to stylelint-config-wikimedia for !important
Change-Id: I861dda02dfcff3304cd29b9ef03304b9d96ef9cb
---
M .stylelintrc
M demos/styles/demo.css
M src/styles/Element.less
M src/styles/layouts/MenuLayout.less
M src/styles/widgets/ComboBoxInputWidget.less
M src/themes/mediawiki/tools.less
6 files changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/58/290358/1
diff --git a/.stylelintrc b/.stylelintrc
index 6f232ea..f35ae1a 100644
--- a/.stylelintrc
+++ b/.stylelintrc
@@ -5,7 +5,6 @@
"block-closing-brace-space-after": null,
"block-no-empty": null,
"block-no-single-line": null,
- "declaration-no-important": null,
"no-descending-specificity": null,
"string-no-newline": true
}
diff --git a/demos/styles/demo.css b/demos/styles/demo.css
index 8a872dc..cce929e 100644
--- a/demos/styles/demo.css
+++ b/demos/styles/demo.css
@@ -82,7 +82,7 @@
.oo-ui-demo-icons .oo-ui-fieldLayout .oo-ui-buttonElement-button
.oo-ui-labelElement-label {
text-transform: capitalize;
- display: inline !important;
+ display: inline !important; /* stylelint-disable-line
declaration-no-important */
}
.oo-ui-demo-icons .oo-ui-fieldLayout .oo-ui-buttonElement-button:hover {
diff --git a/src/styles/Element.less b/src/styles/Element.less
index f8f3389..837d7b0 100644
--- a/src/styles/Element.less
+++ b/src/styles/Element.less
@@ -2,7 +2,7 @@
.oo-ui-element {
&-hidden {
- display: none !important;
+ display: none !important; /* stylelint-disable-line
declaration-no-important */
}
.theme-oo-ui-element();
diff --git a/src/styles/layouts/MenuLayout.less
b/src/styles/layouts/MenuLayout.less
index 8374eb4..fd8fa6e 100644
--- a/src/styles/layouts/MenuLayout.less
+++ b/src/styles/layouts/MenuLayout.less
@@ -27,6 +27,9 @@
bottom: 18em;
}
+ /* FIXME: Find a way to use fewer !important over-rides */
+ /* stylelint-disable declaration-no-important */
+
&.oo-ui-menuLayout-hideMenu {
> .oo-ui-menuLayout-menu {
width: 0 !important;
@@ -104,5 +107,7 @@
}
}
+ /* stylelint-enable declaration-no-important */
+
.theme-oo-ui-menuLayout();
}
diff --git a/src/styles/widgets/ComboBoxInputWidget.less
b/src/styles/widgets/ComboBoxInputWidget.less
index 8360913..9657bb0 100644
--- a/src/styles/widgets/ComboBoxInputWidget.less
+++ b/src/styles/widgets/ComboBoxInputWidget.less
@@ -19,7 +19,7 @@
// Hide the Chrome dropdown arrow for PHP widget, but keep its
functionality.
// It lines up with our own indicator almost perfectly this way.
input::-webkit-calendar-picker-indicator {
- opacity: 0 !important;
+ opacity: 0 !important; /* stylelint-disable-line
declaration-no-important */
position: absolute;
right: 0;
top: 0;
diff --git a/src/themes/mediawiki/tools.less b/src/themes/mediawiki/tools.less
index c635029..5c5b601 100644
--- a/src/themes/mediawiki/tools.less
+++ b/src/themes/mediawiki/tools.less
@@ -89,7 +89,7 @@
.oo-ui-toolGroup {
.oo-ui-widget-enabled {
- border-right: 0 !important;
+ border-right: 0 !important; /* stylelint-disable-line
declaration-no-important */
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/290358
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I861dda02dfcff3304cd29b9ef03304b9d96ef9cb
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
