jenkins-bot has submitted this change and it was merged.
Change subject: Show Special:Nearby error messages correctly
......................................................................
Show Special:Nearby error messages correctly
Also hide the spinner when the error message is shown.
Bug: T125820
Change-Id: Ib3d89e2d266cd3e244044d12658161a2f1db78a0
---
M resources/mobile.nearby/Nearby.js
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mobile.nearby/Nearby.js
b/resources/mobile.nearby/Nearby.js
index a81901e..21dc755 100644
--- a/resources/mobile.nearby/Nearby.js
+++ b/resources/mobile.nearby/Nearby.js
@@ -257,7 +257,8 @@
_super.call( self, options );
} );
} ).fail( function ( errorType ) {
- options.errorType = errorType;
+ options.errorOptions =
self._errorOptions( errorType );
+ self._isLoading = false;
_super.call( self, options );
} );
} else if ( ( options.latitude && options.longitude )
|| options.pageTitle ) {
@@ -268,7 +269,8 @@
this._find( options ).done( function ( options
) {
_super.call( self, options );
} ).fail( function ( errorType ) {
- options.errorType = errorType;
+ options.errorOptions =
self._errorOptions( errorType );
+ self._isLoading = false;
_super.call( self, options );
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/286692
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3d89e2d266cd3e244044d12658161a2f1db78a0
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <bmansu...@wikimedia.org>
Gerrit-Reviewer: Bmansurov <bmansu...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
