jenkins-bot has submitted this change and it was merged.
Change subject: Fix exception type thrown
......................................................................
Fix exception type thrown
A follow up to 72f465c, change the exception type thrown to the one
expected.
Bug: T136037
Change-Id: If1b4146731a571d2461d37850c9f27e503094b67
---
M
app/src/main/java/org/wikipedia/useroption/dataclient/DefaultUserOptionDataClient.java
1 file changed, 3 insertions(+), 6 deletions(-)
Approvals:
BearND: Looks good to me, but someone else must approve
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/app/src/main/java/org/wikipedia/useroption/dataclient/DefaultUserOptionDataClient.java
b/app/src/main/java/org/wikipedia/useroption/dataclient/DefaultUserOptionDataClient.java
index ae94859..599743f 100644
---
a/app/src/main/java/org/wikipedia/useroption/dataclient/DefaultUserOptionDataClient.java
+++
b/app/src/main/java/org/wikipedia/useroption/dataclient/DefaultUserOptionDataClient.java
@@ -7,10 +7,9 @@
import org.wikipedia.Site;
import org.wikipedia.WikipediaApp;
-import org.wikipedia.dataclient.retrofit.RetrofitException;
-import org.wikipedia.dataclient.retrofit.RetrofitFactory;
import org.wikipedia.dataclient.mwapi.MwPostResponse;
import org.wikipedia.dataclient.mwapi.MwQueryResponse;
+import org.wikipedia.dataclient.retrofit.RetrofitFactory;
import org.wikipedia.editing.FetchEditTokenTask;
import org.wikipedia.useroption.UserOption;
@@ -111,15 +110,13 @@
return options;
}
- public void check(@NonNull Site site) {
+ public void check(@NonNull Site site) throws IOException {
if (!success(options)) {
if (badToken()) {
app().getEditTokenStorage().token(site, null);
}
- throw RetrofitException.unexpectedError(
- new RuntimeException("Bad response for site " +
site.host()
- + " = " + result()));
+ throw new IOException("Bad response for site " + site.host() +
" = " + result());
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/290353
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1b4146731a571d2461d37850c9f27e503094b67
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>
Gerrit-Reviewer: BearND <bsitzm...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org>
Gerrit-Reviewer: Mholloway <mhollo...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
