Ejegg has uploaded a new change for review. https://gerrit.wikimedia.org/r/290980
Change subject: Don't cancel payments missing donor details ...................................................................... Don't cancel payments missing donor details We had been assuming that meant a duplicate authorization (see https://phabricator.wikimedia.org/T129935 ) but it can also happen when there's a queue outage. Leave them for manual resolution. Bug: T136038 Change-Id: Ibc788d3a486e0f3260e147b559b197d00b66dd96 --- M PaymentProviders/Adyen/Jobs/ProcessCaptureRequestJob.php 1 file changed, 8 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig refs/changes/80/290980/1 diff --git a/PaymentProviders/Adyen/Jobs/ProcessCaptureRequestJob.php b/PaymentProviders/Adyen/Jobs/ProcessCaptureRequestJob.php index be14beb..83473e5 100644 --- a/PaymentProviders/Adyen/Jobs/ProcessCaptureRequestJob.php +++ b/PaymentProviders/Adyen/Jobs/ProcessCaptureRequestJob.php @@ -60,11 +60,13 @@ ); // Determine if a message exists in the pending queue; if it does not then - // this payment has already been sent to the verified queue. If it does, - // we need to check $capture_requested in case we have requested a capture - // but have not yet received notification of capture success. Either case can - // occur when a donor submits their credit card details multiple times against - // a single order ID. We should cancel all the duplicate authorizations. + // this payment has already been sent to the verified queue, or there is a + // problem with the queue. If it does exist, we need to check + // $capture_requested in case we have requested a capture but have not yet + // received notification of capture success. Either case can occur when a + // donor submits their credit card details multiple times against a single + // order ID. We should cancel duplicate authorizations, but leave payments + // with missing donor details open for potential manual capture. $this->logger->debug( 'Attempting to locate associated message in pending queue.' ); /** * @var \SmashPig\Core\DataStores\KeyedOpaqueDataStore @@ -143,7 +145,7 @@ "ID '{$this->correlationId}'.", $queueMessage ); - return self::ACTION_DUPLICATE; + return self::ACTION_REVIEW; } if ( $queueMessage->captured ) { $this->logger->info( -- To view, visit https://gerrit.wikimedia.org/r/290980 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibc788d3a486e0f3260e147b559b197d00b66dd96 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/SmashPig Gerrit-Branch: master Gerrit-Owner: Ejegg <eeggles...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
