jenkins-bot has submitted this change and it was merged.
Change subject: Use Revision::RAW when checking whether the author of a
revision mentioned themselves
......................................................................
Use Revision::RAW when checking whether the author of a revision mentioned
themselves
It's probably not realistically possible for a revision to be oversighted
by the time generateMentionEvents() runs, but for consistency
we should be using RAW here.
Change-Id: If73b4abe5fbae5cadb75c5e09137299873f2a764
---
M includes/DiscussionParser.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/DiscussionParser.php b/includes/DiscussionParser.php
index 4a8e636..86a416b 100644
--- a/includes/DiscussionParser.php
+++ b/includes/DiscussionParser.php
@@ -156,7 +156,7 @@
continue;
}
// 2. the user mentions themselves
- if ( $user->getId() == $revision->getUser() ) {
+ if ( $user->getId() == $revision->getUser(
Revision::RAW ) ) {
$stats->increment(
'echo.event.mention.error.sameUser' );
continue;
}
--
To view, visit https://gerrit.wikimedia.org/r/290601
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If73b4abe5fbae5cadb75c5e09137299873f2a764
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
