Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/291233
Change subject: Split mediawiki.special.search styles into it's own module
......................................................................
Split mediawiki.special.search styles into it's own module
Having the stylesheet in the same module as the JavaScript code results
in double loading the stylesheets, once with addModuleStyles() as blocking
stylesheets in the head of Special:Search and once with the async load
of the JavaScript code using ResourceLoader.
To prevent the double loading of the stylesheet, the styles are moved to
it's own module (mediawiki.special.search.styles). The JavaScript module
mediawiki.special.search has now no stylesheets anymore.
Change-Id: I65131080b352dd10144f0fe8f20bc064427b2e01
---
M includes/specials/SpecialSearch.php
M resources/Resources.php
2 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/33/291233/1
diff --git a/includes/specials/SpecialSearch.php
b/includes/specials/SpecialSearch.php
index fe1bc62..19be9aa 100644
--- a/includes/specials/SpecialSearch.php
+++ b/includes/specials/SpecialSearch.php
@@ -105,7 +105,7 @@
$out = $this->getOutput();
$out->allowClickjacking();
$out->addModuleStyles( [
- 'mediawiki.special', 'mediawiki.special.search',
'mediawiki.ui', 'mediawiki.ui.button',
+ 'mediawiki.special', 'mediawiki.special.search.styles',
'mediawiki.ui', 'mediawiki.ui.button',
'mediawiki.ui.input',
'mediawiki.widgets.SearchInputWidget.styles',
] );
$this->addHelpLink( 'Help:Searching' );
diff --git a/resources/Resources.php b/resources/Resources.php
index 2d1e921..1e1ea64 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1883,10 +1883,13 @@
'scripts' =>
'resources/src/mediawiki.special/mediawiki.special.recentchanges.js',
'position' => 'top',
],
+ 'mediawiki.special.search.styles' => [
+ 'position' => 'top',
+ 'styles' =>
'resources/src/mediawiki.special/mediawiki.special.search.css',
+ ],
'mediawiki.special.search' => [
'position' => 'top',
'scripts' =>
'resources/src/mediawiki.special/mediawiki.special.search.js',
- 'styles' =>
'resources/src/mediawiki.special/mediawiki.special.search.css',
'dependencies' => 'mediawiki.widgets.SearchInputWidget',
'messages' => [
'powersearch-togglelabel',
--
To view, visit https://gerrit.wikimedia.org/r/291233
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65131080b352dd10144f0fe8f20bc064427b2e01
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
