Volans has uploaded a new change for review.
https://gerrit.wikimedia.org/r/291299
Change subject: MariaDB: use 0/1 instead of off/on for read_only
......................................................................
MariaDB: use 0/1 instead of off/on for read_only
All the other booleans are set with 0/1 and this avoid also issues with
upper/lower case when comparing configurations with pt-config-diff.
Bug: T133333
Change-Id: I1ddbf9f6a0b1d14989c5e73532fadb919a6aee98
---
M manifests/role/mariadb.pp
M modules/mariadb
M templates/mariadb/parsercache.my.cnf.erb
3 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/99/291299/1
diff --git a/manifests/role/mariadb.pp b/manifests/role/mariadb.pp
index 5d235cb..58dfe88 100644
--- a/manifests/role/mariadb.pp
+++ b/manifests/role/mariadb.pp
@@ -105,8 +105,8 @@
}
$read_only = $master ? {
- true => 'off',
- false => 'on',
+ true => 0,
+ false => 1,
}
include standard
@@ -162,8 +162,8 @@
include role::mariadb::ferm
$read_only = $master ? {
- true => 'off',
- false => 'on',
+ true => 0,
+ false => 1,
}
$data_partition = $::hostname ? {
'db1043' => '/a',
@@ -242,8 +242,8 @@
}
$read_only = $master ? {
- true => 'off',
- false => 'on',
+ true => 0,
+ false => 1,
}
class { 'mariadb::config':
diff --git a/modules/mariadb b/modules/mariadb
index 835a582..88ea09c 160000
--- a/modules/mariadb
+++ b/modules/mariadb
-Subproject commit 835a582723d440c393960f2469b74db43fe78b81
+Subproject commit 88ea09c3cd434ce09cd2bea98dc1d096ca572953
diff --git a/templates/mariadb/parsercache.my.cnf.erb
b/templates/mariadb/parsercache.my.cnf.erb
index 657bffd..c2dabd9 100644
--- a/templates/mariadb/parsercache.my.cnf.erb
+++ b/templates/mariadb/parsercache.my.cnf.erb
@@ -25,7 +25,7 @@
server_id = <%= @server_id %>
# Parsercache needs to be writeable (no masters).
-read_only = off
+read_only = 0
log_bin
log_slave_updates
--
To view, visit https://gerrit.wikimedia.org/r/291299
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ddbf9f6a0b1d14989c5e73532fadb919a6aee98
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Volans <rcocci...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
