Krinkle has uploaded a new change for review. Change subject: [Rewrite] Clean up: PHP errors, CSS errors, storage, coding style ......................................................................
[Rewrite] Clean up: PHP errors, CSS errors, storage, coding style PHP errors: * Notice: Undefined offset: 0 in ./mediawiki/extensions/TemplateInfo/TemplateInfo.classes.php on line 42 * Notice: Trying to get property of non-object in .mediawiki/extensions/TemplateInfo/TemplateInfo.classes.php on line 42 CSS errors: * There is no such thing as automatic padding. Property was ignored. Output: * <p/><table/> -> <table><caption/></table> * Use wgExtensionAssetsPath instead of assuming that it will always be wgScript + extensions. This fixes the 404 errors and broken layout for non-default installs (e.g. using mediawiki/extensions.git or bits.wikimedia.org) * Actually output the error message to the user so they know WHAT is wrong with the input (as opposed to just "It is wrong") Storage: * Don't store error messages in the database. Coding style: * Redefine methods with "Html" in the name instead of "HTML". * Refer to the core Html class by its actual name (HTML>Html) * Remove register_global guards per latest version of the BoilerPlate example extensions. * Curly braces. * Whitespace. * Use spaces inside arrays for aligning properties instead of assuming the width of a tab (which we can't since git and gerrit are fixed on 8 by default). Change-Id: Iba5de6bbc0a0a4cdbbc87d7fc5c03bd948e7ea4b --- M .gitreview D ApiQueryTemplateInfo.php R TemplateInfo.class.php M TemplateInfo.hooks.php M TemplateInfo.php A api/ApiQueryTemplateInfo.php R resources/ext.templateInfo.css 7 files changed, 145 insertions(+), 184 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TemplateInfo refs/changes/88/45288/1 -- To view, visit https://gerrit.wikimedia.org/r/45288 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iba5de6bbc0a0a4cdbbc87d7fc5c03bd948e7ea4b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TemplateInfo Gerrit-Branch: rewrite Gerrit-Owner: Krinkle <ttij...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
