jenkins-bot has submitted this change and it was merged.

Change subject: RollbackAction: Don't return true, causes '1' to be output
......................................................................


RollbackAction: Don't return true, causes '1' to be output

Bug: T136375
Change-Id: Id994b7ee7044ce18cf245a219ba290970511ea0f
---
M includes/actions/RollbackAction.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  TheDJ: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/actions/RollbackAction.php 
b/includes/actions/RollbackAction.php
index 65159f2..3e760fd 100644
--- a/includes/actions/RollbackAction.php
+++ b/includes/actions/RollbackAction.php
@@ -97,7 +97,7 @@
                                }
                        }
 
-                       return true;
+                       return;
                }
 
                # NOTE: Permission errors already handled by 
Action::checkExecute.
@@ -142,7 +142,7 @@
                        );
                        $de->showDiff( '', '' );
                }
-               return true;
+               return;
        }
 
        protected function getDescription() {

-- 
To view, visit https://gerrit.wikimedia.org/r/291376
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id994b7ee7044ce18cf245a219ba290970511ea0f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to