jenkins-bot has submitted this change and it was merged. Change subject: Don't fetch duplication notifications ......................................................................
Don't fetch duplication notifications Avoid joining on echo_taget_page to prevent fetching duplicate notifications. Change-Id: Ibcda67ce2fa387d8be0ffcb405bd0692965dddcb --- M includes/mapper/NotificationMapper.php 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/mapper/NotificationMapper.php b/includes/mapper/NotificationMapper.php index 4bd48e9..d941457 100644 --- a/includes/mapper/NotificationMapper.php +++ b/includes/mapper/NotificationMapper.php @@ -181,7 +181,7 @@ } $res = $dbr->select( - array( 'echo_notification', 'echo_event', 'echo_target_page' ), + array( 'echo_notification', 'echo_event' ), '*', $conds, __METHOD__, @@ -191,7 +191,6 @@ ), array( 'echo_event' => array( 'LEFT JOIN', 'notification_event=event_id' ), - 'echo_target_page' => array( 'LEFT JOIN', array( 'notification_event=etp_event', 'notification_user=etp_user' ) ), ) ); -- To view, visit https://gerrit.wikimedia.org/r/291486 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcda67ce2fa387d8be0ffcb405bd0692965dddcb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: master Gerrit-Owner: Sbisson <sbis...@wikimedia.org> Gerrit-Reviewer: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits