Santhosh has uploaded a new change for review. https://gerrit.wikimedia.org/r/291889
Change subject: Avoid passing integers to mw.RegExp.escape ...................................................................... Avoid passing integers to mw.RegExp.escape Passing the index value of the loop to mw.RegExp.escape causes javascript error at str.replace. mw.RegExp.escape expects string parameters. It is not required to escape the loop index here. Follow-up to c81ab8ae5f89056d23a4b0d36066120b9701d07e. Bug: T135743 Change-Id: I818bc2c671193e79848ae183f509473200c6abf5 --- M resources/src/moment-locale-overrides.js 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/89/291889/1 diff --git a/resources/src/moment-locale-overrides.js b/resources/src/moment-locale-overrides.js index 9af0598..dd33b00 100644 --- a/resources/src/moment-locale-overrides.js +++ b/resources/src/moment-locale-overrides.js @@ -27,7 +27,7 @@ if ( mw.config.get( 'wgTranslateNumerals' ) ) { for ( i = 0; i < 10; i++ ) { if ( table[ i ] !== undefined ) { - s = s.replace( new RegExp( mw.RegExp.escape( i ), 'g' ), table[ i ] ); + s = s.replace( new RegExp( i, 'g' ), table[ i ] ); } } } -- To view, visit https://gerrit.wikimedia.org/r/291889 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I818bc2c671193e79848ae183f509473200c6abf5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits